Skip to content

fix: nodes list stops working on sort by uptime scroll down #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 9, 2024
Merged

fix: nodes list stops working on sort by uptime scroll down #1424

merged 7 commits into from
Oct 9, 2024

Conversation

@astandrik
Copy link
Collaborator

@astandrik astandrik commented Oct 8, 2024 •
edited by github-actions bot
Loading

Closes #1383

Stand

CI Results

Test Status: ✅ PASSED

📊 Full Report

Total Passed Failed Flaky Skipped
128 128 0 0 0

Bundle Size: 🔽

Current: 78.96 MB | Main: 79.14 MB
Diff: 0.17 MB (-0.22%)

✅ Bundle size decreased.

ℹ️ CI Information
  • Test recordings for failed tests are available in the full report.
  • Bundle size is measured for the entire 'dist' directory.
  • 📊 indicates links to detailed reports.
  • 🔺 indicates increase, 🔽 decrease, and ✅ no change in bundle size.

@astandrik astandrik changed the title fix: Nodes list stops working on sort by uptime + scroll down fix: nodes list stops working on sort by uptime scroll down Oct 8, 2024
@astandrik
Copy link
Collaborator Author

astandrik commented Oct 8, 2024 •
edited
Loading

tests fail because of large table mocks - this is an expected state

astandrik
astandrik commented Oct 8, 2024
View reviewed changes
artemmufazalov
artemmufazalov previously approved these changes Oct 9, 2024
View reviewed changes
@artemmufazalov
Copy link
Member

artemmufazalov commented Oct 9, 2024

Please, remove all code for test

@astandrik astandrik added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 5ecaecb Oct 9, 2024
6 checks passed
@astandrik astandrik deleted the astandrik.nodes-list-stops-working-1383 branch October 9, 2024 12:49
@ydb-platform-bot ydb-platform-bot mentioned this pull request Oct 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@artemmufazalov artemmufazalov artemmufazalov approved these changes

@Raubzeug Raubzeug Awaiting requested review from Raubzeug Raubzeug is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nodes list stops working on sort by uptime + scroll down

3 participants

@astandrik @artemmufazalov