feat: support custom metrics events #3038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raubzeug
requested review from
adameat,
artemmufazalov and
astandrik
as code owners
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
astandrik
previously approved these changes
Nov 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Yandex Metrica integration to make it more flexible and configurable. The changes move from a simple string-to-number mapping to a structured configuration that supports typed goals and metrica name resolution.
Key changes:
- Introduced a new
yaMetricaConfigstructure that replaces the flatyaMetricaMapproperty - Added a new
reachMetricaGoalhelper function to simplify goal tracking across the application - Integrated metrica tracking for query execution and stopping in the Query Editor components
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/uiFactory/types.ts | Adds yaMetricaConfig with typed goals, replaces yaMetricaMap, and adds generic parameter T for metrica name types |
| src/uiFactory/uiFactory.ts | Updates configureUIFactory signature to support the new generic parameter T |
| src/utils/yaMetrica.ts | Updates to use yaMetricaConfig, makes getMetrica handle optional names, and adds reachMetricaGoal helper function |
| src/containers/Tenant/Query/QueryEditor/QueryEditor.tsx | Adds metrica tracking calls for query execution (execute and explain actions) |
| src/containers/Tenant/Query/QueryEditorControls/QueryEditorControls.tsx | Adds metrica tracking for query stop action |
Comments suppressed due to low confidence (3)
src/utils/yaMetrica.ts:1
- Spreading
querySettingsmay include unnecessary properties in the metrica event. TheQuerySettingstype includes properties likepragmas(string),limitRows(number), and nested configuration objects that could make tracking data verbose and inconsistent. Consider explicitly specifying only the relevant properties (e.g.,queryMode,transactionMode,statisticsMode) to keep tracking data focused and consistent.
import type {UiMetricaGoal} from '../uiFactory/types';
src/utils/yaMetrica.ts:1
- Spreading
querySettingsmay include unnecessary properties in the metrica event. TheQuerySettingstype includes properties likepragmas(string),limitRows(number), and nested configuration objects that could make tracking data verbose and inconsistent. Consider explicitly specifying only the relevant properties (e.g.,queryMode,transactionMode,statisticsMode) to keep tracking data focused and consistent.
import type {UiMetricaGoal} from '../uiFactory/types';
src/utils/yaMetrica.ts:1
- Spreading
querySettingsmay include unnecessary properties in the metrica event. TheQuerySettingstype includes properties likepragmas(string),limitRows(number), and nested configuration objects that could make tracking data verbose and inconsistent. Consider explicitly specifying only the relevant properties (e.g.,queryMode,transactionMode,statisticsMode) to keep tracking data focused and consistent.
import type {UiMetricaGoal} from '../uiFactory/types';
Raubzeug
force-pushed
the
run-query-metrics
branch
from
f3cb7ec to
01777a8
Compare
astandrik
approved these changes
Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3012
CI Results
Test Status: ❌ FAILED
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: 🔺
Current: 47.10 MB | Main: 47.10 MB
Diff: +5.81 KB (0.01%)
ℹ️ CI Information