Skip to content

Commit 06ab434

Browse files
committed
fix review issues
1 parent 56248a0 commit 06ab434

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

CHANGELOG.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@
22
* Refactored `Connection` interface
33
* Removed `CustomOption` and taking client with custom options
44
* Removed `proxy` package
5-
* Improved `db.With()` helper for create child connections
6-
* Setted shared `conn.Pool` for all child `ydb.Connection`
5+
* Improved `db.With()` helper for child connections creation
6+
* Set shared `conn.Pool` for all children `ydb.Connection`
77

88
## 3.12.1
99
* Added `trace.Driver.OnConnPark` event

internal/conn/pool.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,20 @@ import (
1515

1616
type Pool interface {
1717
PoolGetter
18-
TakerReleaser
18+
Taker
19+
Releaser
1920
Pessimizer
2021
}
2122

2223
type PoolGetter interface {
2324
GetConn(endpoint endpoint.Endpoint) Conn
2425
}
2526

26-
type TakerReleaser interface {
27+
type Taker interface {
2728
Take(ctx context.Context) error
29+
}
30+
31+
type Releaser interface {
2832
Release(ctx context.Context) error
2933
}
3034

0 commit comments

Comments
 (0)