fixed linter issues

Author: asmyasnikov

internal/xlist/list.go

@@ -1,6 +1,5 @@
 // Package xlist is a copy of standard container/list but uses generics
 // for strict checks on compile time
-
 package xlist
 
 // Element is an element of a linked list.
@@ -24,6 +23,7 @@ func (e *Element[T]) Next() *Element[T] {
 	if p := e.next; e.list != nil && p != &e.list.root {
 		return p
 	}
+
 	return nil
 }
 
@@ -32,6 +32,7 @@ func (e *Element[T]) Prev() *Element[T] {
 	if p := e.prev; e.list != nil && p != &e.list.root {
 		return p
 	}
+
 	return nil
 }
 
@@ -47,6 +48,7 @@ func (l *List[T]) Init() *List[T] {
 	l.root.next = &l.root
 	l.root.prev = &l.root
 	l.len = 0
+
 	return l
 }
 
@@ -62,6 +64,7 @@ func (l *List[T]) Front() *Element[T] {
 	if l.len == 0 {
 		return nil
 	}
+
 	return l.root.next
 }
 
@@ -70,6 +73,7 @@ func (l *List[T]) Back() *Element[T] {
 	if l.len == 0 {
 		return nil
 	}
+
 	return l.root.prev
 }
 
@@ -88,6 +92,7 @@ func (l *List[T]) insert(e, at *Element[T]) *Element[T] {
 	e.next.prev = e
 	e.list = l
 	l.len++
+
 	return e
 }
 
@@ -129,18 +134,21 @@ func (l *List[T]) Remove(e *Element[T]) T {
 		// in l or l == nil (e is a zero Element) and l.remove will crash
 		l.remove(e)
 	}
+
 	return e.Value
 }
 
 // PushFront inserts a new element e with value v at the front of list l and returns e.
 func (l *List[T]) PushFront(v T) *Element[T] {
 	l.lazyInit()
+
 	return l.insertValue(v, &l.root)
 }
 
 // PushBack inserts a new element e with value v at the back of list l and returns e.
 func (l *List[T]) PushBack(v T) *Element[T] {
 	l.lazyInit()
+
 	return l.insertValue(v, l.root.prev)
 }
 
@@ -151,6 +159,7 @@ func (l *List[T]) InsertBefore(v T, mark *Element[T]) *Element[T] {
 	if mark.list != l {
 		return nil
 	}
+
 	// see comment in List.Remove about initialization of l
 	return l.insertValue(v, mark.prev)
 }
@@ -162,6 +171,7 @@ func (l *List[T]) InsertAfter(v T, mark *Element[T]) *Element[T] {
 	if mark.list != l {
 		return nil
 	}
+
 	// see comment in List.Remove about initialization of l
 	return l.insertValue(v, mark)
 }

internal/xlist/list_test.go

@@ -1,16 +1,14 @@
-// Copyright 2009 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
 package xlist
 
 import "testing"
 
-func checkListLen[T comparable](t *testing.T, l *List[T], len int) bool {
-	if n := l.Len(); n != len {
-		t.Errorf("l.Len() = %d, want %d", n, len)
+func checkListLen[T comparable](t *testing.T, l *List[T], expectedLen int) bool {
+	if n := l.Len(); n != expectedLen {
+		t.Errorf("l.Len() = %d, want %d", n, expectedLen)
+
 		return false
 	}
+
 	return true
 }
 
@@ -26,6 +24,7 @@ func checkListPointers[T comparable](t *testing.T, l *List[T], es []*Element[T])
 		if l.root.next != nil && l.root.next != root || l.root.prev != nil && l.root.prev != root {
 			t.Errorf("l.root.next = %p, l.root.prev = %p; both should both be nil or %p", l.root.next, l.root.prev, root)
 		}
+
 		return
 	}
 	// len(es) > 0
@@ -292,21 +291,29 @@ func TestMove(t *testing.T) {
 
 // Test PushFront, PushBack, PushFrontList, PushBackList with uninitialized List[T]
 func TestZeroList(t *testing.T) {
-	var l1 = new(List[int])
-	l1.PushFront(1)
-	checkList(t, l1, []any{1})
-
-	var l2 = new(List[int])
-	l2.PushBack(1)
-	checkList(t, l2, []any{1})
+	t.Run("PushFront", func(t *testing.T) {
+		l1 := new(List[int])
+		l1.PushFront(1)
+		checkList(t, l1, []any{1})
+
+		t.Run("PushFrontList", func(t *testing.T) {
+			l3 := new(List[int])
+			l3.PushFrontList(l1)
+			checkList(t, l3, []any{1})
+		})
+	})
 
-	var l3 = new(List[int])
-	l3.PushFrontList(l1)
-	checkList(t, l3, []any{1})
+	t.Run("PushBack", func(t *testing.T) {
+		l2 := new(List[int])
+		l2.PushBack(1)
+		checkList(t, l2, []any{1})
 
-	var l4 = new(List[int])
-	l4.PushBackList(l2)
-	checkList(t, l4, []any{1})
+		t.Run("PushBackList", func(t *testing.T) {
+			l4 := new(List[int])
+			l4.PushBackList(l2)
+			checkList(t, l4, []any{1})
+		})
+	})
 }
 
 // Test that a list l is not modified when calling InsertBefore with a mark that is not an element of l.