issue-826: use different struct for logging

Author: Aleksey Grachev

internal/topic/topicreaderinternal/commit_range.go

@@ -24,12 +24,11 @@ func (r *CommitRanges) len() int {
 	return len(r.ranges)
 }
 
-// GetCommitedInfo implements trace.TopicReaderStreamSendCommitMessageStartMessageInfo
-func (r *CommitRanges) GetCommitedInfo() []trace.TopicReaderCommitStartInfo {
-	res := make([]trace.TopicReaderCommitStartInfo, len(r.ranges))
+// GetCommitsInfo implements trace.TopicReaderStreamSendCommitMessageStartMessageInfo
+func (r *CommitRanges) GetCommitsInfo() []trace.TopicReaderStreamCommitInfo {
+	res := make([]trace.TopicReaderStreamCommitInfo, len(r.ranges))
 	for i := range res {
-		res[i] = trace.TopicReaderCommitStartInfo{
-			RequestContext:     r.ranges[i].partitionSession.ctx,
+		res[i] = trace.TopicReaderStreamCommitInfo{
 			Topic:              r.ranges[i].partitionSession.Topic,
 			PartitionID:        r.ranges[i].partitionSession.PartitionID,
 			PartitionSessionID: r.ranges[i].partitionSession.partitionSessionID.ToInt64(),

log/topic.go

@@ -163,24 +163,24 @@ func internalTopic(l *wrapper, d trace.Detailer) (t trace.Topic) { //nolint:gocy
 		ctx := with(context.Background(), TRACE, "ydb", "topic", "reader", "send", "commit", "message")
 		start := time.Now()
 
-		commitedInfo := info.CommitsInfo.GetCommitedInfo()
-		for i := range commitedInfo {
+		commitInfo := info.CommitsInfo.GetCommitsInfo()
+		for i := range commitInfo {
 			l.Log(ctx, "start",
-				String("topic", commitedInfo[i].Topic),
-				Int64("partitions_id", commitedInfo[i].PartitionID),
-				Int64("partitions_session_id", commitedInfo[i].PartitionSessionID),
-				Int64("commit_start_offset", commitedInfo[i].StartOffset),
-				Int64("commit_end_offset", commitedInfo[i].EndOffset),
+				String("topic", commitInfo[i].Topic),
+				Int64("partitions_id", commitInfo[i].PartitionID),
+				Int64("partitions_session_id", commitInfo[i].PartitionSessionID),
+				Int64("commit_start_offset", commitInfo[i].StartOffset),
+				Int64("commit_end_offset", commitInfo[i].EndOffset),
 			)
 		}
 		return func(doneInfo trace.TopicReaderSendCommitMessageDoneInfo) {
-			for i := range commitedInfo {
+			for i := range commitInfo {
 				fields := []Field{
-					String("topic", commitedInfo[i].Topic),
-					Int64("partitions_id", commitedInfo[i].PartitionID),
-					Int64("partitions_session_id", commitedInfo[i].PartitionSessionID),
-					Int64("commit_start_offset", commitedInfo[i].StartOffset),
-					Int64("commit_end_offset", commitedInfo[i].EndOffset),
+					String("topic", commitInfo[i].Topic),
+					Int64("partitions_id", commitInfo[i].PartitionID),
+					Int64("partitions_session_id", commitInfo[i].PartitionSessionID),
+					Int64("commit_start_offset", commitInfo[i].StartOffset),
+					Int64("commit_end_offset", commitInfo[i].EndOffset),
 					latencyField(start),
 				}
 				if doneInfo.Error == nil {

trace/topic.go

@@ -137,14 +137,28 @@ type (
 		CommitsInfo TopicReaderStreamSendCommitMessageStartMessageInfo
 	}
 
+	// TopicReaderStreamCommitInfo
+	//
+	// Experimental
+	//
+	// Notice: This API is EXPERIMENTAL and may be changed or removed in a
+	// later release.
+	TopicReaderStreamCommitInfo struct {
+		Topic              string
+		PartitionID        int64
+		PartitionSessionID int64
+		StartOffset        int64
+		EndOffset          int64
+	}
+
 	// TopicReaderStreamSendCommitMessageStartMessageInfo
 	//
 	// Experimental
 	//
 	// Notice: This API is EXPERIMENTAL and may be changed or removed in a
 	// later release.
 	TopicReaderStreamSendCommitMessageStartMessageInfo interface {
-		GetCommitedInfo() []TopicReaderCommitStartInfo
+		GetCommitsInfo() []TopicReaderStreamCommitInfo
 	}
 
 	// TopicReaderSendCommitMessageDoneInfo