* Changed ydb.WithWideTimeTypes(bool) for allow boolean argument

Author: asmyasnikov

CHANGELOG.md

@@ -1,4 +1,5 @@
 * Added bindings options into `ydb.ParamsFromMap` for bind wide time types
+* Changed `ydb.WithWideTimeTypes(bool)` for allow boolean argument
 
 ## v3.104.1
 * Added export of advanced metric information for QueryService calls

dsn.go

@@ -115,7 +115,7 @@ func parseConnectionString(dataSourceName string) (opts []Option, _ error) {
 			case "numeric":
 				binders = append(binders, xsql.WithQueryBind(bind.NumericArgs{}))
 			case "wide_time_types":
-				binders = append(binders, xsql.WithQueryBind(bind.WideTimeTypes{}))
+				binders = append(binders, xsql.WithQueryBind(bind.WideTimeTypes(true)))
 			default:
 				if strings.HasPrefix(transformer, tablePathPrefixTransformer) {
 					prefix, err := extractTablePathPrefixFromBinderName(transformer)

dsn_test.go

@@ -182,7 +182,7 @@ func TestParse(t *testing.T) {
 				xsql.WithDefaultQueryMode(xtable.ScriptingQueryMode),
 				xsql.WithQueryBind(bind.PositionalArgs{}),
 				xsql.WithQueryBind(bind.AutoDeclare{}),
-				xsql.WithQueryBind(bind.WideTimeTypes{}),
+				xsql.WithQueryBind(bind.WideTimeTypes(true)),
 			},
 			err: nil,
 		},

internal/bind/wide_time_types.go

@@ -7,9 +7,13 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/value"
 )
 
-type WideTimeTypes struct{}
+type WideTimeTypes bool
+
+func (b WideTimeTypes) ToYdb(sql string, args ...any) (yql string, newArgs []any, _ error) {
+	if !b {
+		return sql, args, nil
+	}
 
-func (m WideTimeTypes) ToYdb(sql string, args ...any) (yql string, newArgs []any, _ error) {
 	newArgs = make([]any, 0, len(args))
 	for _, arg := range args {
 		switch t := arg.(type) {
@@ -42,6 +46,6 @@ func (m WideTimeTypes) ToYdb(sql string, args ...any) (yql string, newArgs []any
 	return sql, newArgs, nil
 }
 
-func (m WideTimeTypes) blockID() blockID {
+func (b WideTimeTypes) blockID() blockID {
 	return blockCastArgs
 }

internal/bind/wide_time_types_test.go

@@ -58,7 +58,7 @@ func TestWideTimeTypesBind(t *testing.T) {
 			},
 		},
 		{
-			bind: WideTimeTypes{},
+			bind: WideTimeTypes(true),
 			sql:  `SELECT ?, ?`,
 			args: []any{
 				100,
@@ -71,7 +71,7 @@ func TestWideTimeTypesBind(t *testing.T) {
 			},
 		},
 		{
-			bind: WideTimeTypes{},
+			bind: WideTimeTypes(true),
 			sql:  `SELECT ?, ?`,
 			args: []any{
 				time.Unix(123, 456),
@@ -84,7 +84,7 @@ func TestWideTimeTypesBind(t *testing.T) {
 			},
 		},
 		{
-			bind: WideTimeTypes{},
+			bind: WideTimeTypes(true),
 			sql:  `SELECT ?, ?`,
 			args: []any{
 				time.Duration(123) * time.Millisecond,

params_test.go

@@ -260,7 +260,7 @@ func TestParamsFromMap(t *testing.T) {
 		params := ydb.ParamsFromMap(map[string]any{
 			"a": time.Date(1900, 1, 1, 0, 0, 0, 123456, time.UTC),
 			"b": time.Duration(123) * time.Nanosecond,
-		}, ydb.WithWideTimeTypes())
+		}, ydb.WithWideTimeTypes(true))
 		pp, err := params.ToYDB(&allocator.Allocator{})
 		require.NoError(t, err)
 		require.EqualValues(t, map[string]*Ydb.TypedValue{

query_bind_test.go

@@ -583,7 +583,7 @@ SELECT $p0;`,
 			b: testutil.QueryBind(
 				ydb.WithAutoDeclare(),
 				ydb.WithPositionalArgs(),
-				ydb.WithWideTimeTypes(),
+				ydb.WithWideTimeTypes(true),
 			),
 			sql:  `SELECT ?;`,
 			args: []interface{}{time.Unix(123, 456)},

sql.go

@@ -189,8 +189,8 @@ func WithPositionalArgs() QueryBindConnectorOption {
 	return xsql.WithQueryBind(bind.PositionalArgs{})
 }
 
-func WithWideTimeTypes() QueryBindConnectorOption {
-	return xsql.WithQueryBind(bind.WideTimeTypes{})
+func WithWideTimeTypes(b bool) QueryBindConnectorOption {
+	return xsql.WithQueryBind(bind.WideTimeTypes(b))
 }
 
 func WithNumericArgs() QueryBindConnectorOption {