add idempotent flag to trace table OnDoTx

Author: asmyasnikov

internal/table/retry.go

@@ -78,7 +78,7 @@ func parseOptions(ctx context.Context, opts ...retryOption) retryOptions {
 
 func doTx(ctx context.Context, c SessionProvider, op table.TxOperation, opts ...retryOption) (err error) {
 	options := parseOptions(ctx, opts...)
-	attempts, onIntermediate := 0, trace.TableOnPoolDoTx(options.trace, &ctx)
+	attempts, onIntermediate := 0, trace.TableOnPoolDoTx(options.trace, &ctx, options.options.Idempotent)
 	defer func() {
 		onIntermediate(err)(attempts, err)
 	}()

log/table.go

@@ -65,28 +65,35 @@ func Table(log Logger, details trace.Details) trace.Table {
 		) func(
 			trace.PoolDoTxDoneInfo,
 		) {
-			log.Tracef(`doTx start`)
+			idempotent := info.Idempotent
+			log.Tracef(`doTx start {idempotent:%t}`,
+				idempotent,
+			)
 			start := time.Now()
 			return func(info trace.PoolDoTxInternalInfo) func(trace.PoolDoTxDoneInfo) {
 				if info.Error == nil {
-					log.Tracef(`doTx intermediate {latency:"%s"}`,
+					log.Tracef(`doTx intermediate {latency:"%s",idempotent:%t}`,
 						time.Since(start),
+						idempotent,
 					)
 				} else {
-					log.Debugf(`doTx intermediate {latency:"%s",error:"%v"}`,
+					log.Debugf(`doTx intermediate {latency:"%s",idempotent:%t,error:"%v"}`,
 						time.Since(start),
+						idempotent,
 						info.Error,
 					)
 				}
 				return func(info trace.PoolDoTxDoneInfo) {
 					if info.Error == nil {
-						log.Tracef(`doTx done {latency:"%s",attempts:%d}`,
+						log.Tracef(`doTx done {latency:"%s",idempotent:%t,attempts:%d}`,
 							time.Since(start),
+							idempotent,
 							info.Attempts,
 						)
 					} else {
-						log.Errorf(`doTx failed {latency:"%s",attempts:%d,error:"%v"}`,
+						log.Errorf(`doTx failed {latency:"%s",idempotent:%t,attempts:%d,error:"%v"}`,
 							time.Since(start),
+							idempotent,
 							info.Attempts,
 							info.Error,
 						)

trace/table.go

@@ -299,7 +299,8 @@ type (
 		// Pointer to context provide replacement of context in trace callback function.
 		// Warning: concurrent access to pointer on client side must be excluded.
 		// Safe replacement of context are provided only inside callback function
-		Context *context.Context
+		Context    *context.Context
+		Idempotent bool
 	}
 	PoolDoTxInternalInfo struct {
 		Error error