Skip to content

Commit 17a901b

Browse files
authored
Merge pull request #1532 from ydb-platform/ci-run-slo-on-push-master
Run SLO Tests on push master
2 parents 3ecd6b9 + 238cd6a commit 17a901b

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

.github/workflows/slo.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
name: slo
22

33
on:
4+
push:
5+
branches:
6+
- master
47
pull_request:
58
branches:
69
- master
@@ -81,8 +84,11 @@ jobs:
8184
./tests/slo/.bin/${{matrix.sdk.id}}_linux_amd64 create grpc://localhost:2135 /Root/testdb
8285
./tests/slo/.bin/${{matrix.sdk.id}}_linux_amd64 run grpc://localhost:2135 /Root/testdb \
8386
-prom-pgw localhost:9091 \
84-
-report-period 500 \
87+
-report-period 250 \
8588
-time ${{inputs.slo_workload_duration_seconds || 600}} \
8689
-read-rps ${{inputs.slo_workload_read_max_rps || 1000}} \
87-
-write-rps ${{inputs.slo_workload_write_max_rps || 100}}
90+
-write-rps ${{inputs.slo_workload_write_max_rps || 100}} \
91+
-read-timeout 10000 \
92+
-write-timeout 10000 \
93+
-shutdown-time 30
8894
./tests/slo/.bin/${{matrix.sdk.id}}_linux_amd64 cleanup grpc://localhost:2135 /Root/testdb

tests/slo/internal/metrics/metrics.go

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ type (
3232
retriesFailureTotal *prometheus.CounterVec
3333

3434
pendingOperations *prometheus.GaugeVec
35-
// TODO:
3635
// sdk_cpu_usage_seconds_total *prometheus.CounterVec
3736
// sdk_memory_usage_bytes *prometheus.GaugeVec
3837
// sdk_connections_open *prometheus.GaugeVec
@@ -54,39 +53,39 @@ func New(url, ref, label, jobName string) (*Metrics, error) {
5453
}
5554

5655
m.errorsTotal = prometheus.NewCounterVec(
57-
prometheus.CounterOpts{ //nolint:promlinter
56+
prometheus.CounterOpts{
5857
Name: "sdk_errors_total",
5958
Help: "Total number of errors encountered, categorized by error type.",
6059
},
6160
[]string{"error_type"},
6261
)
6362

6463
m.operationsTotal = prometheus.NewCounterVec(
65-
prometheus.CounterOpts{ //nolint:promlinter
64+
prometheus.CounterOpts{
6665
Name: "sdk_operations_total",
6766
Help: "Total number of operations, categorized by type attempted by the SDK.",
6867
},
6968
[]string{"operation_type"},
7069
)
7170

7271
m.operationsSuccessTotal = prometheus.NewCounterVec(
73-
prometheus.CounterOpts{ //nolint:promlinter
72+
prometheus.CounterOpts{
7473
Name: "sdk_operations_success_total",
7574
Help: "Total number of successful operations, categorized by type.",
7675
},
7776
[]string{"operation_type"},
7877
)
7978

8079
m.operationsFailureTotal = prometheus.NewCounterVec(
81-
prometheus.CounterOpts{ //nolint:promlinter
80+
prometheus.CounterOpts{
8281
Name: "sdk_operations_failure_total",
8382
Help: "Total number of failed operations, categorized by type.",
8483
},
8584
[]string{"operation_type"},
8685
)
8786

8887
m.operationLatencySeconds = prometheus.NewHistogramVec(
89-
prometheus.HistogramOpts{ //nolint:promlinter
88+
prometheus.HistogramOpts{
9089
Name: "sdk_operation_latency_seconds",
9190
Help: "Latency of operations performed by the SDK in seconds, categorized by type and status.",
9291
Buckets: []float64{
@@ -109,31 +108,31 @@ func New(url, ref, label, jobName string) (*Metrics, error) {
109108
)
110109

111110
m.retryAttemptsTotal = prometheus.NewCounterVec(
112-
prometheus.CounterOpts{ //nolint:promlinter
111+
prometheus.CounterOpts{
113112
Name: "sdk_retry_attempts_total",
114113
Help: "Total number of retry attempts, categorized by operation type.",
115114
},
116115
[]string{"operation_type"},
117116
)
118117

119118
m.retriesSuccessTotal = prometheus.NewCounterVec(
120-
prometheus.CounterOpts{ //nolint:promlinter
119+
prometheus.CounterOpts{
121120
Name: "sdk_retries_success_total",
122121
Help: "Total number of successful retries, categorized by operation type.",
123122
},
124123
[]string{"operation_type"},
125124
)
126125

127126
m.retriesFailureTotal = prometheus.NewCounterVec(
128-
prometheus.CounterOpts{ //nolint:promlinter
127+
prometheus.CounterOpts{
129128
Name: "sdk_retries_failure_total",
130129
Help: "Total number of failed retries, categorized by operation type.",
131130
},
132131
[]string{"operation_type"},
133132
)
134133

135134
m.pendingOperations = prometheus.NewGaugeVec(
136-
prometheus.GaugeOpts{ //nolint:promlinter
135+
prometheus.GaugeOpts{
137136
Name: "sdk_pending_operations",
138137
Help: "Current number of pending operations, categorized by type.",
139138
},

0 commit comments

Comments
 (0)