Skip to content

Commit 200688b

Browse files
authored
Merge pull request #1459 from ydb-platform/split-conn-request-metrics
Split `ydb_go_sdk_ydb_driver_conn_requests` metrtcs
2 parents fb252b8 + fa86fe4 commit 200688b

File tree

2 files changed

+9
-3
lines changed

2 files changed

+9
-3
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
* Changed `ydb_go_sdk_ydb_driver_conn_requests` metrics splitted to `ydb_go_sdk_ydb_driver_conn_request_statuses` and `ydb_go_sdk_ydb_driver_conn_request_methods`
12
* Fixed metadata for operation service connection
23
* Fixed composing query traces in call `db.Query.Do[Tx]` using option `query.WithTrace`
34

metrics/driver.go

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,8 @@ func driver(config Config) (t trace.Driver) {
1818
balancerUpdates := config.WithSystem("balancer").CounterVec("updates", "cause")
1919
conns := config.GaugeVec("conns", "endpoint", "node_id")
2020
banned := config.WithSystem("conn").GaugeVec("banned", "endpoint", "node_id", "cause")
21-
requests := config.WithSystem("conn").CounterVec("requests", "status", "method", "endpoint", "node_id")
21+
requestStatuses := config.WithSystem("conn").CounterVec("request_statuses", "status", "endpoint", "node_id")
22+
requestMethods := config.WithSystem("conn").CounterVec("request_methods", "method", "endpoint", "node_id")
2223
tli := config.CounterVec("transaction_locks_invalidated")
2324

2425
type endpointKey struct {
@@ -35,8 +36,12 @@ func driver(config Config) (t trace.Driver) {
3536

3637
return func(info trace.DriverConnInvokeDoneInfo) {
3738
if config.Details()&trace.DriverConnEvents != 0 {
38-
requests.With(map[string]string{
39+
requestStatuses.With(map[string]string{
3940
"status": errorBrief(info.Error),
41+
"endpoint": endpoint,
42+
"node_id": strconv.FormatUint(uint64(nodeID), 10),
43+
}).Inc()
44+
requestMethods.With(map[string]string{
4045
"method": string(method),
4146
"endpoint": endpoint,
4247
"node_id": strconv.FormatUint(uint64(nodeID), 10),
@@ -58,7 +63,7 @@ func driver(config Config) (t trace.Driver) {
5863

5964
return func(info trace.DriverConnNewStreamDoneInfo) {
6065
if config.Details()&trace.DriverConnStreamEvents != 0 {
61-
requests.With(map[string]string{
66+
requestStatuses.With(map[string]string{
6267
"status": errorBrief(info.Error),
6368
"method": string(method),
6469
"endpoint": endpoint,

0 commit comments

Comments
 (0)