Skip to content

Commit 20277c1

Browse files
committed
fix linter issues
1 parent 79d6aad commit 20277c1

File tree

5 files changed

+12
-7
lines changed

5 files changed

+12
-7
lines changed

example_test.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ func Example_databaseSQL() {
6060
if err != nil {
6161
log.Fatal(err)
6262
}
63-
defer db.Close() // cleanup resources
63+
defer func() { _ = db.Close() }() // cleanup resources
6464

6565
var (
6666
query = `SELECT 42 as id, "my string" as myStr`
@@ -76,7 +76,7 @@ func Example_databaseSQL() {
7676
return nil
7777
}, retry.WithDoTxRetryOptions(retry.WithIdempotent(true)))
7878
if err != nil {
79-
log.Fatal(err)
79+
log.Printf("query failed: %v", err)
8080
}
8181
}
8282

internal/xsql/convert.go

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,10 +4,10 @@ import (
44
"database/sql"
55
"database/sql/driver"
66
"fmt"
7-
internal "github.com/ydb-platform/ydb-go-sdk/v3/internal/table"
8-
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
97
"time"
108

9+
internal "github.com/ydb-platform/ydb-go-sdk/v3/internal/table"
10+
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
1111
"github.com/ydb-platform/ydb-go-sdk/v3/table"
1212
"github.com/ydb-platform/ydb-go-sdk/v3/table/types"
1313
)
@@ -35,6 +35,7 @@ func toQueryParams(values []driver.NamedValue) *table.QueryParameters {
3535
return table.NewQueryParameters(opts...)
3636
}
3737

38+
//nolint:gocyclo
3839
func primitiveToValue(v interface{}) (value types.Value, err error) {
3940
if valuer, ok := v.(driver.Valuer); ok {
4041
v, err = valuer.Value()

sugar/params_go1.18.go

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,9 @@ import (
1313
// GenerateDeclareSection generates DECLARE section text in YQL query by params
1414
//
1515
// Warning: This is an experimental feature and could change at any time
16-
func GenerateDeclareSection[T *table.QueryParameters | []table.ParameterOption | []sql.NamedArg](params T) (string, error) {
16+
func GenerateDeclareSection[T *table.QueryParameters | []table.ParameterOption | []sql.NamedArg](
17+
params T,
18+
) (string, error) {
1719
switch v := any(params).(type) {
1820
case *table.QueryParameters:
1921
return internal.GenerateDeclareSection(v)

sugar/params_go1.18_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,12 +5,13 @@ package sugar
55

66
import (
77
"database/sql"
8-
"github.com/stretchr/testify/require"
98
"sort"
109
"strings"
1110
"testing"
1211
"time"
1312

13+
"github.com/stretchr/testify/require"
14+
1415
"github.com/ydb-platform/ydb-go-sdk/v3/table"
1516
"github.com/ydb-platform/ydb-go-sdk/v3/table/types"
1617
)

sugar/params_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,13 @@
44
package sugar
55

66
import (
7-
"github.com/stretchr/testify/require"
87
"sort"
98
"strings"
109
"testing"
1110
"time"
1211

12+
"github.com/stretchr/testify/require"
13+
1314
"github.com/ydb-platform/ydb-go-sdk/v3/table"
1415
"github.com/ydb-platform/ydb-go-sdk/v3/table/types"
1516
)

0 commit comments

Comments
 (0)