Skip to content

Commit 20f189b

Browse files
committed
remove redundant options for cluster.Get
1 parent cf49e6e commit 20f189b

File tree

1 file changed

+4
-10
lines changed

1 file changed

+4
-10
lines changed

internal/cluster/cluster.go

Lines changed: 4 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ func parseOptions(opts ...crudOption) *crudOptionsHolder {
129129

130130
type Getter interface {
131131
// Get gets conn from cluster
132-
Get(ctx context.Context, opts ...crudOption) (cc conn.Conn, err error)
132+
Get(ctx context.Context) (cc conn.Conn, err error)
133133
}
134134

135135
type Inserter interface {
@@ -247,13 +247,11 @@ func (c *cluster) Close(ctx context.Context) (err error) {
247247

248248
// Get returns next available connection.
249249
// It returns error on given deadline cancellation or when cluster become closed.
250-
func (c *cluster) Get(ctx context.Context, opts ...crudOption) (cc conn.Conn, err error) {
250+
func (c *cluster) Get(ctx context.Context) (cc conn.Conn, err error) {
251251
var cancel context.CancelFunc
252252
ctx, cancel = context.WithTimeout(ctx, MaxGetConnTimeout)
253253
defer cancel()
254254

255-
options := parseOptions(opts...)
256-
257255
if c.closed {
258256
return nil, errors.WithStackTrace(ErrClusterClosed)
259257
}
@@ -268,13 +266,9 @@ func (c *cluster) Get(ctx context.Context, opts ...crudOption) (cc conn.Conn, er
268266
}()
269267

270268
if e, ok := ContextEndpoint(ctx); ok {
271-
if options.withLock {
272-
c.mu.RLock()
273-
}
269+
c.mu.RLock()
274270
cc, ok = c.endpoints[e.NodeID()]
275-
if options.withLock {
276-
c.mu.RUnlock()
277-
}
271+
c.mu.RUnlock()
278272
if ok && cc.IsState(
279273
conn.Created,
280274
conn.Online,

0 commit comments

Comments
 (0)