Merge pull request #1328 from AlekseyGlushenok/metrics-over-table

Metrics over table

Author: asmyasnikov

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Added metrics over `db.Table().Do()` and `db.Table().DoTx()`
 * Added method `ydb.ParamsBuilder().Param(name).Any(value)` to add custom `types.Value`
 * Upgraded dependencies:
   * `google.golang.org/grpc` - from `v1.57.1` to `v1.62.1`

metrics/table.go

@@ -12,6 +12,7 @@ import (
 func table(config Config) (t trace.Table) {
 	config = config.WithSystem("table")
 	alive := config.GaugeVec("sessions", "node_id")
+	session := config.WithSystem("session")
 	config = config.WithSystem("pool")
 	limit := config.GaugeVec("limit")
 	size := config.GaugeVec("size")
@@ -82,6 +83,42 @@ func table(config Config) (t trace.Table) {
 
 		return nil
 	}
+	{
+		latency := session.WithSystem("query").TimerVec("latency")
+		errs := session.WithSystem("query").CounterVec("errs", "status")
+		attempts := session.WithSystem("query").HistogramVec("attempts", []float64{0, 1, 2, 3, 4, 5, 7, 10})
+		t.OnDo = func(info trace.TableDoStartInfo) func(trace.TableDoDoneInfo) {
+			start := time.Now()
+
+			return func(doneInfo trace.TableDoDoneInfo) {
+				if config.Details()&trace.TableSessionQueryEvents != 0 {
+					latency.With(nil).Record(time.Since(start))
+					errs.With(map[string]string{
+						"status": errorBrief(doneInfo.Error),
+					})
+					attempts.With(nil).Record(float64(doneInfo.Attempts))
+				}
+			}
+		}
+	}
+	{
+		latency := session.WithSystem("tx").TimerVec("latency")
+		errs := session.WithSystem("tx").CounterVec("errs", "status")
+		attempts := session.WithSystem("tx").HistogramVec("attempts", []float64{0, 1, 2, 3, 4, 5, 7, 10})
+		t.OnDoTx = func(info trace.TableDoTxStartInfo) func(trace.TableDoTxDoneInfo) {
+			start := time.Now()
+
+			return func(doneInfo trace.TableDoTxDoneInfo) {
+				if config.Details()&trace.TableSessionQueryEvents != 0 {
+					latency.With(nil).Record(time.Since(start))
+					errs.With(map[string]string{
+						"status": errorBrief(doneInfo.Error),
+					})
+					attempts.With(nil).Record(float64(doneInfo.Attempts))
+				}
+			}
+		}
+	}
 
 	return t
 }