Skip to content

Commit 36141fb

Browse files
committed
prettify xtest grpc stream msgs
1 parent f887b4d commit 36141fb

File tree

2 files changed

+25
-41
lines changed

2 files changed

+25
-41
lines changed

internal/xtest/grpclogger.go

Lines changed: 25 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -35,13 +35,11 @@ func (l GrpcLogger) UnaryClientInterceptor(
3535
opts ...grpc.CallOption,
3636
) error {
3737
err := invoker(ctx, method, req, reply, cc, opts...)
38-
l.t.Logf(
39-
"UnaryClientInterceptor: %s - err: %v\n\nreq:\n%v\n\nresp:\n%v",
40-
method,
41-
err,
42-
req,
43-
reply,
44-
)
38+
if err != nil {
39+
l.t.Logf("UnaryClientInterceptor: %s - err: %v\n\nreq:\n%v\n\nresp:\n%v", method, err, req, reply)
40+
} else {
41+
l.t.Logf("UnaryClientInterceptor: %s:\n\nreq:\n%v\n\nresp:\n%v", method, req, reply)
42+
}
4543

4644
return err
4745
}
@@ -59,12 +57,11 @@ func (l GrpcLogger) StreamClientInterceptor(
5957
if stream != nil {
6058
stream = streamWrapper
6159
}
62-
l.t.Logf(
63-
"StreamStart: %v with err '%v' (streamID: %v)",
64-
method,
65-
err,
66-
streamWrapper.streamID,
67-
)
60+
if err != nil {
61+
l.t.Logf("StreamStart: %v with err '%v' (streamID: %v)", method, err, streamWrapper.streamID)
62+
} else {
63+
l.t.Logf("StreamStart: %v (streamID: %v)", method, streamWrapper.streamID)
64+
}
6865

6966
return stream, err
7067
}
@@ -81,21 +78,33 @@ func newGrpcLoggerStream(stream grpc.ClientStream, t testing.TB) grpcLoggerStrea
8178

8279
func (g grpcLoggerStream) CloseSend() error {
8380
err := g.ClientStream.CloseSend()
84-
g.t.Logf("CloseSend: %v (streamID: %v)", err, g.streamID)
81+
if err != nil {
82+
g.t.Logf("CloseSend: %v (streamID: %v)", err, g.streamID)
83+
} else {
84+
g.t.Logf("CloseSend (streamID: %v)", g.streamID)
85+
}
8586

8687
return err
8788
}
8889

8990
func (g grpcLoggerStream) SendMsg(m interface{}) error {
9091
err := g.ClientStream.SendMsg(m)
91-
g.t.Logf("SendMsg (streamID: %v) with err '%v':\n%v ", g.streamID, err, m)
92+
if err != nil {
93+
g.t.Logf("SendMsg (streamID: %v) with err '%v':\n%v ", g.streamID, err, m)
94+
} else {
95+
g.t.Logf("SendMsg (streamID: %v):\n%v ", g.streamID, m)
96+
}
9297

9398
return err
9499
}
95100

96101
func (g grpcLoggerStream) RecvMsg(m interface{}) error {
97102
err := g.ClientStream.RecvMsg(m)
98-
g.t.Logf("RecvMsg (streamID: %v) with err '%v':\n%v ", g.streamID, err, m)
103+
if err != nil {
104+
g.t.Logf("RecvMsg (streamID: %v) with err '%v':\n%v ", g.streamID, err, m)
105+
} else {
106+
g.t.Logf("RecvMsg (streamID: %v):\n%v ", g.streamID, m)
107+
}
99108

100109
return err
101110
}

trace/driver_gtrace.go

Lines changed: 0 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)