enhance struct value construction

Author: positiveviking

internal/value/value.go

@@ -502,6 +502,19 @@ type StructValueProto struct {
 	Values []*Ydb.Value
 }
 
+func (s *StructValueProto) Grow(size int) {
+	if cap(s.Fields) < size {
+		newFields := make([]StructField, 0, size)
+		newFields = append(newFields, s.Fields...)
+		s.Fields = newFields
+	}
+	if cap(s.Values) < size {
+		newValues := make([]*Ydb.Value, 0, size)
+		newValues = append(newValues, s.Values...)
+		s.Values = newValues
+	}
+}
+
 func (s *StructValueProto) Add(name string, value V) {
 	s.Fields = append(s.Fields, StructField{
 		Name: name,

table/types/value.go

@@ -147,18 +147,28 @@ func ListValue(vs ...Value) Value {
 
 type tStructValueProto value.StructValueProto
 
-type StructValueOption func(*tStructValueProto)
+type StructValueOption interface {
+	apply(*tStructValueProto)
+}
+
+type structField struct {
+	name  string
+	value Value
+}
+
+func (f structField) apply(p *tStructValueProto) {
+	(*value.StructValueProto)(p).Add(f.name, f.value)
+}
 
 func StructFieldValue(name string, v Value) StructValueOption {
-	return func(p *tStructValueProto) {
-		(*value.StructValueProto)(p).Add(name, v)
-	}
+	return structField{name: name, value: v}
 }
 
 func StructValue(opts ...StructValueOption) Value {
 	var p tStructValueProto
+	(*value.StructValueProto)(&p).Grow(len(opts))
 	for _, opt := range opts {
-		opt(&p)
+		opt.apply(&p)
 	}
 	return value.StructValue((*value.StructValueProto)(&p))
 }