fix context which is used for closing session

4el0ve4ek · 4el0ve4ek · commit 3adc8ad86f27 · 2024-12-21T18:56:57.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Fixed connections pool leak on closing sessions
+
 ## v3.95.3
 * Supported of `database/sql/driver.Valuer` interfaces for params which passed to query using sql driver 
 * Exposed `credentials/credentials.OAuth2Config` OAuth2 config
diff --git a/internal/pool/pool.go b/internal/pool/pool.go
@@ -302,7 +302,7 @@ func makeAsyncCloseItemFunc[PT ItemConstraint[T], T any](
 			defer closeItemCancel()
 
 			if d := p.config.closeTimeout; d > 0 {
-				closeItemCtx, closeItemCancel = xcontext.WithTimeout(ctx, d)
+				closeItemCtx, closeItemCancel = xcontext.WithTimeout(closeItemCtx, d)
 				defer closeItemCancel()
 			}
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+* Fixed connections pool leak on closing sessions`
	`2`	`+`
`1`	`3`	`## v3.95.3`
`2`	`4`	* Supported of `database/sql/driver.Valuer` interfaces for params which passed to query using sql driver
`3`	`5`	* Exposed `credentials/credentials.OAuth2Config` OAuth2 config
Original file line number	Diff line number	Diff line change
`@@ -302,7 +302,7 @@ func makeAsyncCloseItemFunc[PT ItemConstraint[T], T any](`
`302`	`302`	`defer closeItemCancel()`
`303`	`303`
`304`	`304`	`if d := p.config.closeTimeout; d > 0 {`
`305`		`- closeItemCtx, closeItemCancel = xcontext.WithTimeout(ctx, d)`
	`305`	`+ closeItemCtx, closeItemCancel = xcontext.WithTimeout(closeItemCtx, d)`
`306`	`306`	`defer closeItemCancel()`
`307`	`307`	`}`
`308`	`308`