Merge pull request #434 Removed message level partitioning from experimental topic API

Author: rekby

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Removed message level partitioning from experimental topic API. It is unavailable on server side yet.
 * Supported `NullValue` type as received type from `YDB`
 * Supported `types.SetValue` type
 * Added `types.CastTo(types.Value, destination)` public method for cast `types.Value` to golang native type value destination

internal/topic/topicwriterinternal/message.go

@@ -15,33 +15,38 @@ import (
 var errNoRawContent = xerrors.Wrap(errors.New("ydb: internal state error - no raw message content"))
 
 type Message struct {
-	SeqNo        int64
-	CreatedAt    time.Time
-	Data         io.Reader
-	Partitioning PublicPartitioning
+	SeqNo     int64
+	CreatedAt time.Time
+	Data      io.Reader
+
+	// partitioning at level message available by protocol, but doesn't available by current server implementation
+	// the field hidden from public access for prevent runtime errors.
+	// it will be published after implementation on server side.
+	futurePartitioning PublicFuturePartitioning
 }
 
-type PublicPartitioning struct {
+// PublicFuturePartitioning will be published in feature, after server implementation completed.
+type PublicFuturePartitioning struct {
 	messageGroupID string
 	partitionID    int64
 	hasPartitionID bool
 }
 
-func (p PublicPartitioning) ToRaw() rawtopicwriter.Partitioning {
+func (p PublicFuturePartitioning) ToRaw() rawtopicwriter.Partitioning {
 	if p.hasPartitionID {
 		return rawtopicwriter.NewPartitioningPartitionID(p.partitionID)
 	}
 	return rawtopicwriter.NewPartitioningMessageGroup(p.messageGroupID)
 }
 
-func NewPartitioningWithMessageGroupID(id string) PublicPartitioning {
-	return PublicPartitioning{
+func NewPartitioningWithMessageGroupID(id string) PublicFuturePartitioning {
+	return PublicFuturePartitioning{
 		messageGroupID: id,
 	}
 }
 
-func NewPartitioningWithPartitionID(id int64) PublicPartitioning {
-	return PublicPartitioning{
+func NewPartitioningWithPartitionID(id int64) PublicFuturePartitioning {
+	return PublicFuturePartitioning{
 		partitionID:    id,
 		hasPartitionID: true,
 	}

internal/topic/topicwriterinternal/writer_options.go

@@ -94,7 +94,7 @@ func WithMaxQueueLen(num int) PublicWriterOption {
 	}
 }
 
-func WithPartitioning(partitioning PublicPartitioning) PublicWriterOption {
+func WithPartitioning(partitioning PublicFuturePartitioning) PublicWriterOption {
 	return func(cfg *WriterReconnectorConfig) {
 		cfg.defaultPartitioning = partitioning.ToRaw()
 	}

internal/topic/topicwriterinternal/writer_reconnector.go

@@ -573,12 +573,12 @@ func createRawMessageData(
 	res.SeqNo = mess.SeqNo
 
 	switch {
-	case mess.Partitioning.hasPartitionID:
+	case mess.futurePartitioning.hasPartitionID:
 		res.Partitioning.Type = rawtopicwriter.PartitioningPartitionID
-		res.Partitioning.PartitionID = mess.Partitioning.partitionID
-	case mess.Partitioning.messageGroupID != "":
+		res.Partitioning.PartitionID = mess.futurePartitioning.partitionID
+	case mess.futurePartitioning.messageGroupID != "":
 		res.Partitioning.Type = rawtopicwriter.PartitioningMessageGroupID
-		res.Partitioning.MessageGroupID = mess.Partitioning.messageGroupID
+		res.Partitioning.MessageGroupID = mess.futurePartitioning.messageGroupID
 	default:
 		// pass
 	}

topic/topicoptions/topicoptions_writer.go

@@ -4,7 +4,6 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/grpcwrapper/rawtopic/rawtopiccommon"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicwriterinternal"
 	"github.com/ydb-platform/ydb-go-sdk/v3/topic/topictypes"
-	"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicwriter"
 )
 
 type WriterOption = topicwriterinternal.PublicWriterOption
@@ -91,15 +90,6 @@ func WithSyncWrite(sync bool) WriterOption {
 	return topicwriterinternal.WithWaitAckOnWrite(sync)
 }
 
-// WithWriterPartitioning explicit set partitioning for write session
-//
-// # Experimental
-//
-// Notice: This API is EXPERIMENTAL and may be changed or removed in a later release.
-func WithWriterPartitioning(partitioning topicwriter.Partitioning) WriterOption {
-	return topicwriterinternal.WithPartitioning(partitioning)
-}
-
 type (
 	// WithOnWriterConnectedInfo present information, received from server
 	//

topic/topicwriter/topicwriter.go

@@ -7,8 +7,7 @@ import (
 )
 
 type (
-	Message      = topicwriterinternal.Message
-	Partitioning = topicwriterinternal.PublicPartitioning
+	Message = topicwriterinternal.Message
 )
 
 var ErrQueueLimitExceed = topicwriterinternal.PublicErrQueueIsFull