Merge pull request #728 from ydb-platform/context

`xcontext.With{Cancel,Timeout}` with stack trace record

Author: asmyasnikov

CHANGELOG.md

@@ -1,3 +1,5 @@
+* Implemented `xcontext.With{Cancel,Timeout}` with stack record and switched all usages from standard `context.With{Cancel,Timeout}`
+
 ## v3.46.0
 * Refactored package `log` for support typed fields in log messages
 

connection.go

@@ -81,6 +81,8 @@ type Connection interface {
 	Topic() topic.Client
 }
 
+var _ Connection = (*Driver)(nil)
+
 // Driver type provide access to YDB service clients
 type Driver struct { //nolint:maligned
 	userInfo *dsn.UserInfo

connection_test.go

@@ -30,15 +30,15 @@ type Worker struct {
 	tasks chan backgroundTask
 
 	closed      bool
-	stop        xcontext.CancelErrFunc
+	stop        context.CancelFunc
 	closeReason error
 }
 
 type CallbackFunc func(ctx context.Context)
 
 func NewWorker(parent context.Context) *Worker {
 	w := Worker{}
-	w.ctx, w.stop = xcontext.WithErrCancel(parent)
+	w.ctx, w.stop = xcontext.WithCancel(parent)
 
 	return &w
 }
@@ -88,7 +88,7 @@ func (b *Worker) Close(ctx context.Context, err error) error {
 			b.closeReason = errClosedWithNilReason
 		}
 
-		b.stop(err)
+		b.stop()
 	})
 	if resErr != nil {
 		return resErr
@@ -121,7 +121,7 @@ func (b *Worker) CloseReason() error {
 func (b *Worker) init() {
 	b.onceInit.Do(func() {
 		if b.ctx == nil {
-			b.ctx, b.stop = xcontext.WithErrCancel(context.Background())
+			b.ctx, b.stop = xcontext.WithCancel(context.Background())
 		}
 		b.tasks = make(chan backgroundTask)
 		b.tasksCompleted = make(empty.Chan)

integration-insecure.txt

@@ -15,6 +15,7 @@ import (
 	discoveryConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/discovery/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/repeater"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xcontext"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsync"
 	"github.com/ydb-platform/ydb-go-sdk/v3/retry"
@@ -94,9 +95,9 @@ func (b *Balancer) clusterDiscoveryAttempt(ctx context.Context) (err error) {
 	}()
 
 	if dialTimeout := b.driverConfig.DialTimeout(); dialTimeout > 0 {
-		ctx, cancel = context.WithTimeout(ctx, dialTimeout)
+		ctx, cancel = xcontext.WithTimeout(ctx, dialTimeout)
 	} else {
-		ctx, cancel = context.WithCancel(ctx)
+		ctx, cancel = xcontext.WithCancel(ctx)
 	}
 	defer cancel()
 

integration-secure.txt

@@ -11,6 +11,7 @@ import (
 	"sync"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xcontext"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 )
 
@@ -19,7 +20,7 @@ const (
 )
 
 func checkFastestAddress(ctx context.Context, addresses []string) string {
-	ctx, cancel := context.WithCancel(ctx)
+	ctx, cancel := xcontext.WithCancel(ctx)
 	defer cancel()
 
 	type result struct {

internal/background/worker.go

@@ -16,6 +16,7 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/endpoint"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/meta"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/response"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xcontext"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 	"github.com/ydb-platform/ydb-go-sdk/v3/trace"
 )
@@ -180,7 +181,7 @@ func (c *conn) realConn(ctx context.Context) (cc *grpc.ClientConn, err error) {
 
 	if dialTimeout := c.config.DialTimeout(); dialTimeout > 0 {
 		var cancel context.CancelFunc
-		ctx, cancel = context.WithTimeout(ctx, dialTimeout)
+		ctx, cancel = xcontext.WithTimeout(ctx, dialTimeout)
 		defer cancel()
 	}
 
@@ -395,7 +396,7 @@ func (c *conn) NewStream(
 	}()
 
 	var cancel context.CancelFunc
-	ctx, cancel = context.WithCancel(ctx)
+	ctx, cancel = xcontext.WithCancel(ctx)
 
 	defer func() {
 		if err != nil {