Merge pull request #1351 from ydb-platform/buffer

* Fixed `internal/xstrings.Buffer()` leak without call `buffer.Free()`

Author: asmyasnikov

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Fixed `internal/xstrings.Buffer()` leak without call `buffer.Free()`
 * Removed double quotas from goroutine labels background workers for prevent problem with pprof
 
 ## v3.75.2

internal/xerrors/issues.go

@@ -77,6 +77,7 @@ func (e *withIssuesError) isYdbError() {}
 
 func (e *withIssuesError) Error() string {
 	b := xstring.Buffer()
+	defer b.Free()
 	if len(e.reason) > 0 {
 		b.WriteString(e.reason)
 		b.WriteString(", issues: [")

internal/xerrors/retryable.go

@@ -39,6 +39,7 @@ func (re *retryableError) IsRetryObjectValid() bool {
 
 func (re *retryableError) Error() string {
 	b := xstring.Buffer()
+	defer b.Free()
 	b.WriteString(re.Name())
 	fmt.Fprintf(b, " (code = %d, source error = %q", re.code, re.err.Error())
 	if len(re.traceID) > 0 {

internal/xerrors/transport.go

@@ -61,6 +61,7 @@ func WithNodeID(nodeID uint32) nodeIDOption {
 
 func (e *transportError) Error() string {
 	b := xstring.Buffer()
+	defer b.Free()
 	b.WriteString(e.Name())
 	fmt.Fprintf(b, " (code = %d, source error = %q", e.status.Code(), e.err.Error())
 	if len(e.address) > 0 {