Skip to content

Commit 4cdd105

Browse files
authored
Merge pull request #186 from ydb-platform/ratelimiter-error-check
* Fixed bug with check acquire error over `ydb.IsRatelimiterAcquireEr…
2 parents 6836e65 + fb3186f commit 4cdd105

File tree

3 files changed

+39
-1
lines changed

3 files changed

+39
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
* Fixed bug with check acquire error over `ydb.IsRatelimiterAcquireError`
12
* Added full changelog link to github release description
23

34
## v3.16.11

internal/ratelimiter/errors/errors.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ func NewAcquire(amoount uint64, err error) ratelimiter.AcquireError {
3232
}
3333

3434
func IsAcquireError(err error) bool {
35-
ae := acquireError{}
35+
var ae *acquireError
3636
return errors.As(err, &ae)
3737
}
3838

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
package errors
2+
3+
import (
4+
"fmt"
5+
"testing"
6+
7+
"github.com/ydb-platform/ydb-go-sdk/v3/internal/errors"
8+
)
9+
10+
func TestIsAcquireError(t *testing.T) {
11+
for _, err := range []error{
12+
&acquireError{},
13+
errors.WithStackTrace(&acquireError{}),
14+
errors.WithStackTrace(fmt.Errorf("%w", &acquireError{})),
15+
} {
16+
t.Run("", func(t *testing.T) {
17+
if !IsAcquireError(err) {
18+
t.Errorf("not acquire error: %v", err)
19+
}
20+
})
21+
}
22+
}
23+
24+
func TestToAcquireError(t *testing.T) {
25+
for _, err := range []error{
26+
&acquireError{},
27+
errors.WithStackTrace(&acquireError{}),
28+
errors.WithStackTrace(fmt.Errorf("%w", &acquireError{})),
29+
} {
30+
t.Run("", func(t *testing.T) {
31+
ae := ToAcquireError(err)
32+
if ae == nil {
33+
t.Errorf("not acquire error: %v", err)
34+
}
35+
})
36+
}
37+
}

0 commit comments

Comments
 (0)