renamed internal/xsql to internal.connector

Author: asmyasnikov

driver.go

@@ -14,6 +14,7 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/discovery"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/conn"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/connector"
 	internalCoordination "github.com/ydb-platform/ydb-go-sdk/v3/internal/coordination"
 	coordinationConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/coordination/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/credentials"
@@ -36,7 +37,6 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/topic/topicclientinternal"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xcontext"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
-	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsync"
 	"github.com/ydb-platform/ydb-go-sdk/v3/log"
 	"github.com/ydb-platform/ydb-go-sdk/v3/operation"
@@ -93,7 +93,7 @@ type (
 		topic        *xsync.Once[*topicclientinternal.Client]
 		topicOptions []topicoptions.TopicOption
 
-		databaseSQLOptions []xsql.Option
+		databaseSQLOptions []connector.Option
 
 		pool *conn.Pool
 

dsn.go

@@ -9,10 +9,10 @@ import (
 	"github.com/ydb-platform/ydb-go-sdk/v3/balancers"
 	"github.com/ydb-platform/ydb-go-sdk/v3/credentials"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/bind"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/connector"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/dsn"
 	tableSql "github.com/ydb-platform/ydb-go-sdk/v3/internal/table/conn"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
-	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql"
 )
 
 const tablePathPrefixTransformer = "table_path_prefix"
@@ -64,41 +64,41 @@ func parseConnectionString(dataSourceName string) (opts []Option, _ error) {
 		if mode == tableSql.UnknownQueryMode {
 			return nil, xerrors.WithStackTrace(fmt.Errorf("unknown query mode: %s", queryMode))
 		}
-		opts = append(opts, withConnectorOptions(xsql.WithDefaultQueryMode(mode)))
+		opts = append(opts, withConnectorOptions(connector.WithDefaultQueryMode(mode)))
 	} else if queryMode := info.Params.Get("query_mode"); queryMode != "" {
 		mode := tableSql.QueryModeFromString(queryMode)
 		if mode == tableSql.UnknownQueryMode {
 			return nil, xerrors.WithStackTrace(fmt.Errorf("unknown query mode: %s", queryMode))
 		}
-		opts = append(opts, withConnectorOptions(xsql.WithDefaultQueryMode(mode)))
+		opts = append(opts, withConnectorOptions(connector.WithDefaultQueryMode(mode)))
 	}
 	if fakeTx := info.Params.Get("go_fake_tx"); fakeTx != "" {
 		for _, queryMode := range strings.Split(fakeTx, ",") {
 			mode := tableSql.QueryModeFromString(queryMode)
 			if mode == tableSql.UnknownQueryMode {
 				return nil, xerrors.WithStackTrace(fmt.Errorf("unknown query mode: %s", queryMode))
 			}
-			opts = append(opts, withConnectorOptions(xsql.WithFakeTx(mode)))
+			opts = append(opts, withConnectorOptions(connector.WithFakeTx(mode)))
 		}
 	}
 	if info.Params.Has("go_query_bind") {
-		var binders []xsql.Option
+		var binders []connector.Option
 		queryTransformers := strings.Split(info.Params.Get("go_query_bind"), ",")
 		for _, transformer := range queryTransformers {
 			switch transformer {
 			case "declare":
-				binders = append(binders, xsql.WithQueryBind(bind.AutoDeclare{}))
+				binders = append(binders, connector.WithQueryBind(bind.AutoDeclare{}))
 			case "positional":
-				binders = append(binders, xsql.WithQueryBind(bind.PositionalArgs{}))
+				binders = append(binders, connector.WithQueryBind(bind.PositionalArgs{}))
 			case "numeric":
-				binders = append(binders, xsql.WithQueryBind(bind.NumericArgs{}))
+				binders = append(binders, connector.WithQueryBind(bind.NumericArgs{}))
 			default:
 				if strings.HasPrefix(transformer, tablePathPrefixTransformer) {
 					prefix, err := extractTablePathPrefixFromBinderName(transformer)
 					if err != nil {
 						return nil, xerrors.WithStackTrace(err)
 					}
-					binders = append(binders, xsql.WithQueryBind(bind.TablePathPrefix(prefix)))
+					binders = append(binders, connector.WithQueryBind(bind.TablePathPrefix(prefix)))
 				} else {
 					return nil, xerrors.WithStackTrace(
 						fmt.Errorf("unknown query rewriter: %s", transformer),

dsn_test.go

@@ -8,14 +8,14 @@ import (
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/bind"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/connector"
 	querySql "github.com/ydb-platform/ydb-go-sdk/v3/internal/query/conn"
 	tableSql "github.com/ydb-platform/ydb-go-sdk/v3/internal/table/conn"
-	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql"
 )
 
 func TestParse(t *testing.T) {
-	newConnector := func(opts ...xsql.Option) *xsql.Connector {
-		c := &xsql.Connector{}
+	newConnector := func(opts ...connector.Option) *connector.Connector {
+		c := &connector.Connector{}
 		for _, opt := range opts {
 			if opt != nil {
 				if err := opt.Apply(c); err != nil {
@@ -40,7 +40,7 @@ func TestParse(t *testing.T) {
 	for _, tt := range []struct {
 		dsn           string
 		opts          []config.Option
-		connectorOpts []xsql.Option
+		connectorOpts []connector.Option
 		err           error
 	}{
 		{
@@ -70,8 +70,8 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
+			connectorOpts: []connector.Option{
+				connector.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
 			},
 			err: nil,
 		},
@@ -82,9 +82,9 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
-				xsql.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
+			connectorOpts: []connector.Option{
+				connector.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
+				connector.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
 			},
 			err: nil,
 		},
@@ -95,10 +95,10 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
-				xsql.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
-				xsql.WithQueryBind(bind.NumericArgs{}),
+			connectorOpts: []connector.Option{
+				connector.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
+				connector.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
+				connector.WithQueryBind(bind.NumericArgs{}),
 			},
 			err: nil,
 		},
@@ -109,10 +109,10 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
-				xsql.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
-				xsql.WithQueryBind(bind.PositionalArgs{}),
+			connectorOpts: []connector.Option{
+				connector.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
+				connector.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
+				connector.WithQueryBind(bind.PositionalArgs{}),
 			},
 			err: nil,
 		},
@@ -123,10 +123,10 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
-				xsql.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
-				xsql.WithQueryBind(bind.AutoDeclare{}),
+			connectorOpts: []connector.Option{
+				connector.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
+				connector.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
+				connector.WithQueryBind(bind.AutoDeclare{}),
 			},
 			err: nil,
 		},
@@ -137,9 +137,9 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
-				xsql.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
+			connectorOpts: []connector.Option{
+				connector.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
+				connector.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
 			},
 			err: nil,
 		},
@@ -150,11 +150,11 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
-				xsql.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
-				xsql.WithQueryBind(bind.PositionalArgs{}),
-				xsql.WithQueryBind(bind.AutoDeclare{}),
+			connectorOpts: []connector.Option{
+				connector.WithDefaultQueryMode(tableSql.ScriptingQueryMode),
+				connector.WithQueryBind(bind.TablePathPrefix("path/to/tables")),
+				connector.WithQueryBind(bind.PositionalArgs{}),
+				connector.WithQueryBind(bind.AutoDeclare{}),
 			},
 			err: nil,
 		},
@@ -165,9 +165,9 @@ func TestParse(t *testing.T) {
 				config.WithEndpoint("localhost:2135"),
 				config.WithDatabase("/local"),
 			},
-			connectorOpts: []xsql.Option{
-				xsql.WithFakeTx(tableSql.ScriptingQueryMode),
-				xsql.WithFakeTx(tableSql.SchemeQueryMode),
+			connectorOpts: []connector.Option{
+				connector.WithFakeTx(tableSql.ScriptingQueryMode),
+				connector.WithFakeTx(tableSql.SchemeQueryMode),
 			},
 			err: nil,
 		},

internal/xsql/conn.go renamed to internal/connector/conn.go

@@ -1,4 +1,4 @@
-package xsql
+package connector
 
 import (
 	"context"
@@ -238,7 +238,7 @@ func (c *connWrapper) IsColumnExists(ctx context.Context, tableName, columnName
 func (c *connWrapper) IsTableExists(ctx context.Context, tableName string) (tableExists bool, finalErr error) {
 	tableName = c.normalizePath(tableName)
 	onDone := trace.DatabaseSQLOnConnIsTableExists(c.connector.trace, &ctx,
-		stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql.(*connWrapper).IsTableExists"),
+		stack.FunctionID("github.com/ydb-platform/ydb-go-sdk/v3/internal/connector.(*connWrapper).IsTableExists"),
 		tableName,
 	)
 	defer func() {

internal/xsql/conn_test.go renamed to internal/connector/conn_test.go

@@ -1,4 +1,4 @@
-package xsql
+package connector
 
 import "context"
 

internal/xsql/connector.go renamed to internal/connector/connector.go

@@ -1,4 +1,4 @@
-package xsql
+package connector
 
 import (
 	"context"

internal/xsql/errors.go renamed to internal/connector/errors.go

@@ -1,4 +1,4 @@
-package xsql
+package connector
 
 import (
 	"database/sql/driver"

internal/xsql/options.go renamed to internal/connector/options.go

@@ -1,4 +1,4 @@
-package xsql
+package connector
 
 import (
 	"time"

internal/xsql/unwrap.go renamed to internal/connector/unwrap.go

@@ -1,4 +1,4 @@
-package xsql
+package connector
 
 import (
 	"database/sql"

options.go

@@ -14,6 +14,7 @@ import (
 	balancerConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/balancer/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/certificates"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/conn"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/connector"
 	coordinationConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/coordination/config"
 	discoveryConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/discovery/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/dsn"
@@ -23,7 +24,6 @@ import (
 	scriptingConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/scripting/config"
 	tableConfig "github.com/ydb-platform/ydb-go-sdk/v3/internal/table/config"
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
-	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xsql"
 	"github.com/ydb-platform/ydb-go-sdk/v3/log"
 	"github.com/ydb-platform/ydb-go-sdk/v3/retry/budget"
 	"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptions"
@@ -521,7 +521,7 @@ func WithSessionPoolIdleThreshold(idleThreshold time.Duration) Option {
 	return func(ctx context.Context, d *Driver) error {
 		d.tableOptions = append(d.tableOptions, tableConfig.WithIdleThreshold(idleThreshold))
 		d.databaseSQLOptions = append(d.databaseSQLOptions,
-			xsql.WithIdleThreshold(idleThreshold),
+			connector.WithIdleThreshold(idleThreshold),
 		)
 
 		return nil
@@ -772,7 +772,7 @@ func WithTraceTopic(t trace.Topic, opts ...trace.TopicComposeOption) Option { //
 func WithTraceDatabaseSQL(t trace.DatabaseSQL, opts ...trace.DatabaseSQLComposeOption) Option { //nolint:gocritic
 	return func(ctx context.Context, d *Driver) error {
 		d.databaseSQLOptions = append(d.databaseSQLOptions,
-			xsql.WithTrace(
+			connector.WithTrace(
 				&t,
 				append(
 					[]trace.DatabaseSQLComposeOption{