Skip to content

Commit 5a9a219

Browse files
committed
fix traceparent header
1 parent 8f7b1a4 commit 5a9a219

File tree

2 files changed

+5
-59
lines changed

2 files changed

+5
-59
lines changed

spans/driver.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ func traceparent(traceID string, spanID string) string {
2121
b.WriteString(traceID)
2222
b.WriteByte('-')
2323
b.WriteString(spanID)
24-
b.WriteString("-0")
24+
b.WriteString("-01")
2525

2626
return b.String()
2727
}

spans/driver_test.go

Lines changed: 4 additions & 58 deletions
Original file line numberDiff line numberDiff line change
@@ -1,71 +1,17 @@
11
package spans
22

33
import (
4-
"fmt"
5-
"strings"
64
"testing"
75

86
"github.com/stretchr/testify/require"
9-
10-
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xstring"
117
)
128

13-
func traceparentFmt(traceID string, spanID string) string {
14-
return fmt.Sprintf("00-%s-%s-0", traceID, spanID)
15-
}
16-
17-
func BenchmarkTraceparentFmt(b *testing.B) {
18-
b.ReportAllocs()
19-
for i := 0; i < b.N; i++ {
20-
traceparent := traceparentFmt("8e3790822789a6917883e08d0eeb783e", "729d847ca290963e")
21-
require.Equal(b, "00-8e3790822789a6917883e08d0eeb783e-729d847ca290963e-0", traceparent)
22-
}
23-
}
24-
25-
func traceparentBuilder(traceID string, spanID string) string {
26-
var b strings.Builder
27-
b.WriteString("00-")
28-
b.WriteString(traceID)
29-
b.WriteByte('-')
30-
b.WriteString(spanID)
31-
b.WriteString("-0")
32-
33-
return b.String()
34-
}
35-
36-
func BenchmarkTraceparentBuilder(b *testing.B) {
37-
b.ReportAllocs()
38-
for i := 0; i < b.N; i++ {
39-
traceparent := traceparentBuilder("8e3790822789a6917883e08d0eeb783e", "729d847ca290963e")
40-
require.Equal(b, "00-8e3790822789a6917883e08d0eeb783e-729d847ca290963e-0", traceparent)
41-
}
42-
}
43-
44-
func traceparentBuffer(traceID string, spanID string) string {
45-
b := xstring.Buffer()
46-
defer b.Free()
47-
48-
b.WriteString("00-")
49-
b.WriteString(traceID)
50-
b.WriteByte('-')
51-
b.WriteString(spanID)
52-
b.WriteString("-0")
53-
54-
return b.String()
55-
}
56-
57-
func BenchmarkTraceparentBuffer(b *testing.B) {
58-
b.ReportAllocs()
59-
for i := 0; i < b.N; i++ {
60-
traceparent := traceparentBuffer("8e3790822789a6917883e08d0eeb783e", "729d847ca290963e")
61-
require.Equal(b, "00-8e3790822789a6917883e08d0eeb783e-729d847ca290963e-0", traceparent)
62-
}
63-
}
64-
659
func BenchmarkTraceparent(b *testing.B) {
6610
b.ReportAllocs()
6711
for i := 0; i < b.N; i++ {
68-
traceparent := traceparent("8e3790822789a6917883e08d0eeb783e", "729d847ca290963e")
69-
require.Equal(b, "00-8e3790822789a6917883e08d0eeb783e-729d847ca290963e-0", traceparent)
12+
require.Equal(b,
13+
"00-8e3790822789a6917883e08d0eeb783e-729d847ca290963e-00",
14+
traceparent("8e3790822789a6917883e08d0eeb783e", "729d847ca290963e"),
15+
)
7016
}
7117
}

0 commit comments

Comments
 (0)