* Removed support of YDB_LOG_NO_COLOR environment variable

* Changed default behaviour of internal logger to without coloring
* Fixed coloring (to true) with environment variable `YDB_LOG_SEVERITY_LEVEL`

Author: asmyasnikov

CHANGELOG.md

@@ -3,6 +3,9 @@
 * Added `database/sql` events for tracing `database/sql` driver events
 * Added internal logging for `database/sql` events
 * Supports `YDB_LOG_DETAILS` environment variable for specify scope of log messages
+* Removed support of `YDB_LOG_NO_COLOR` environment variable
+* Changed default behaviour of internal logger to without coloring
+* Fixed coloring (to true) with environment variable `YDB_LOG_SEVERITY_LEVEL`
 
 ## v3.33.0
 * Added `retry.DoTx` helper for retrying `database/sql` transactions 

README.md

@@ -126,7 +126,6 @@ Next packages provide debug tooling:
 |----------------------------------|-----------|---------|--------------------------------------------------------------------------------------------------------------------------|
 | `YDB_SSL_ROOT_CERTIFICATES_FILE` | `string`  |         | path to certificates file                                                                                                |
 | `YDB_LOG_SEVERITY_LEVEL`         | `string`  | `quiet` | severity logging level of internal driver logger. Supported: `trace`, `debug`, `info`, `warn`, `error`, `fatal`, `quiet` |
-| `YDB_LOG_DETAILS`                | `string`  | `.*`    | pattern for lookup internal logger logs                                                                                  |
-| `YDB_LOG_NO_COLOR`               | `bool`    | `false` | set any non empty value to disable colouring logs with internal driver logger                                            |
+| `YDB_LOG_DETAILS`                | `string`  | `.*`    | regexp for lookup internal logger logs                                                                                   |
 | `GRPC_GO_LOG_VERBOSITY_LEVEL`    | `integer` |         | set to `99` to see grpc logs                                                                                             |
 | `GRPC_GO_LOG_SEVERITY_LEVEL`     | `string`  |         | set to `info` to see grpc logs                                                                                           |

connection.go

@@ -376,7 +376,7 @@ func open(ctx context.Context, opts ...Option) (_ Connection, err error) {
 					),
 					WithNamespace("ydb"),
 					WithMinLevel(log.FromString(logLevel)),
-					WithNoColor(os.Getenv("YDB_LOG_NO_COLOR") != ""),
+					WithColoring(),
 				),
 			)
 		}

discovery/discovery_e2e_test.go

@@ -68,6 +68,7 @@ func TestDiscovery(t *testing.T) {
 			ydb.WithOutWriter(os.Stdout),
 			ydb.WithErrWriter(os.Stdout),
 			ydb.WithMinLevel(log.WARN),
+			ydb.WithColoring(),
 		),
 		ydb.WithUserAgent(userAgent),
 		ydb.WithRequestsType(requestType),

internal/logger/log.go

@@ -20,15 +20,15 @@ type logger struct {
 	external  log.Logger
 	namespace string
 	minLevel  level.Level
-	noColor   bool
+	coloring  bool
 	out       io.Writer
 	err       io.Writer
 }
 
 func New(opts ...Option) *logger {
 	l := &logger{
 		minLevel: level.INFO,
-		noColor:  false,
+		coloring: false,
 		out:      os.Stdout,
 		err:      os.Stderr,
 	}
@@ -39,25 +39,25 @@ func New(opts ...Option) *logger {
 }
 
 func (l *logger) format(format string, logLevel level.Level) string {
-	if l.noColor {
+	if l.coloring {
 		return fmt.Sprintf(
-			"%-5s %23s %26s %s\n",
+			"%s%-5s %23s %26s%s %s%s%s\n",
+			logLevel.BoldColor(),
 			logLevel.String(),
 			time.Now().Format(dateLayout),
 			"["+l.namespace+"]",
+			colorReset,
+			logLevel.Color(),
 			format,
+			colorReset,
 		)
 	}
 	return fmt.Sprintf(
-		"%s%-5s %23s %26s%s %s%s%s\n",
-		logLevel.BoldColor(),
+		"%-5s %23s %26s %s\n",
 		logLevel.String(),
 		time.Now().Format(dateLayout),
 		"["+l.namespace+"]",
-		colorReset,
-		logLevel.Color(),
 		format,
-		colorReset,
 	)
 }
 
@@ -144,6 +144,6 @@ func (l *logger) WithName(name string) log.Logger {
 		err:       l.err,
 		namespace: join(l.namespace, name),
 		minLevel:  l.minLevel,
-		noColor:   l.noColor,
+		coloring:  l.coloring,
 	}
 }

internal/logger/options.go

@@ -9,9 +9,13 @@ import (
 
 type Option func(l *logger)
 
-func WithNoColor(b bool) Option {
+func Nop() Option {
+	return func(l *logger) {}
+}
+
+func WithColoring() Option {
 	return func(l *logger) {
-		l.noColor = b
+		l.coloring = true
 	}
 }
 

logger_options.go

@@ -18,8 +18,15 @@ func WithMinLevel(minLevel log.Level) LoggerOption {
 	return LoggerOption(logger.WithMinLevel(level.Level(minLevel)))
 }
 
+// WithNoColor specified coloring of log messages
+//
+// Deprecated: has no effect now, use WithColoring instead
 func WithNoColor(b bool) LoggerOption {
-	return LoggerOption(logger.WithNoColor(b))
+	return LoggerOption(logger.Nop())
+}
+
+func WithColoring() LoggerOption {
+	return LoggerOption(logger.WithColoring())
 }
 
 func WithExternalLogger(external log.Logger) LoggerOption {