improve test of sugar.DSN() + simplify call t.Fatal(fmt.Sprintf("")) to t.Fatalf("")

Author: asmyasnikov

internal/dsn/dsn_test.go

@@ -2,7 +2,6 @@ package dsn
 
 import (
 	"context"
-	"fmt"
 	"testing"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/config"
@@ -69,7 +68,7 @@ func TestParseConnectionString(t *testing.T) {
 		t.Run(test.connectionString, func(t *testing.T) {
 			options, err := Parse(test.connectionString)
 			if !xerrors.Is(err, test.error) {
-				t.Fatal(fmt.Sprintf("Received unexpected error:\n%+v", err))
+				t.Fatalf("Received unexpected error:\n%+v", err)
 			}
 			config := config.New(options...)
 			testutil.Equal(t, test.secure, config.Secure())
@@ -79,7 +78,7 @@ func TestParseConnectionString(t *testing.T) {
 			if credentials := config.Credentials(); credentials != nil {
 				token, err = credentials.Token(context.Background())
 				if err != nil {
-					t.Fatal(fmt.Sprintf("Received unexpected error:\n%+v", err))
+					t.Fatalf("Received unexpected error:\n%+v", err)
 				}
 			} else {
 				token = ""

sugar/dsn_test.go

@@ -1,8 +1,10 @@
 package sugar
 
 import (
-	"fmt"
 	"testing"
+
+	"github.com/ydb-platform/ydb-go-sdk/v3/config"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/dsn"
 )
 
 func TestDSN(t *testing.T) {
@@ -39,9 +41,23 @@ func TestDSN(t *testing.T) {
 		},
 	} {
 		t.Run(test.dsn, func(t *testing.T) {
-			dsn := DSN(test.endpoint, test.database, test.secure)
-			if dsn != test.dsn {
-				t.Fatal(fmt.Sprintf("Unexpected result: %s, exp: %s", dsn, test.dsn))
+			s := DSN(test.endpoint, test.database, test.secure)
+			if s != test.dsn {
+				t.Fatalf("Unexpected result: %s, exp: %s", s, test.dsn)
+			}
+			opts, err := dsn.Parse(s)
+			if err != nil {
+				t.Fatalf("")
+			}
+			config := config.New(opts...)
+			if config.Endpoint() != test.endpoint {
+				t.Fatalf("Unexpected endpoint: %s, exp: %s", config.Endpoint(), test.endpoint)
+			}
+			if config.Database() != test.database {
+				t.Fatalf("Unexpected database: %s, exp: %s", config.Database(), test.database)
+			}
+			if config.Secure() != test.secure {
+				t.Fatalf("Unexpected secure flag: %v, exp: %v", config.Secure(), test.secure)
 			}
 		})
 	}

testutil/assert.go

@@ -1,24 +1,21 @@
 package testutil
 
 import (
-	"fmt"
 	"reflect"
 	"testing"
 )
 
 func Equal(t *testing.T, expected, actual interface{}) {
 	t.Helper()
 	if !reflect.DeepEqual(expected, actual) {
-		t.Fatal(fmt.Sprintf("Not equal: \n"+
-			"expected: %#v\n"+
-			"actual  : %#v", expected, actual))
+		t.Fatalf("Not equal:\n\tactual: %#v\n\texpected: %#v", actual, expected)
 	}
 }
 
 func NoError(t *testing.T, err error) {
 	t.Helper()
 	if err != nil {
-		t.Fatal(fmt.Sprintf("Received unexpected error:\n%+v", err))
+		t.Fatalf("Received unexpected error: %+v", err)
 	}
 }