Skip to content

Commit 63d58fe

Browse files
committed
Fixed xsql.Rows error checking
1 parent b869f24 commit 63d58fe

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
* Fixed `xsql.Rows` error checking
2+
13
## v3.36.0
24
* Changed behavior on `result.Err()` on truncated result (returns non-retryable error now, exclude `StreamExecuteScanQuery`)
35
* Added `ydb.WithIgnoreTruncated` option for disabling errors on truncated flag

internal/xsql/rows.go

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,7 @@ func (r *rows) Columns() []string {
4646

4747
func (r *rows) NextResultSet() error {
4848
r.nextSet.Do(func() {})
49-
if !r.result.NextResultSet(context.Background()) {
50-
return io.EOF
51-
}
52-
return nil
49+
return r.result.NextResultSetErr(context.Background())
5350
}
5451

5552
func (r *rows) HasNextResultSet() bool {
@@ -58,14 +55,17 @@ func (r *rows) HasNextResultSet() bool {
5855

5956
func (r *rows) Next(dst []driver.Value) (err error) {
6057
r.nextSet.Do(func() {
61-
r.result.NextResultSet(context.Background())
58+
err = r.result.NextResultSetErr(context.Background())
6259
})
63-
if !r.result.NextRow() {
64-
return io.EOF
60+
if err != nil {
61+
return r.conn.checkClosed(xerrors.WithStackTrace(err))
6562
}
6663
if err = r.result.Err(); err != nil {
6764
return r.conn.checkClosed(xerrors.WithStackTrace(err))
6865
}
66+
if !r.result.NextRow() {
67+
return io.EOF
68+
}
6969
values := make([]indexed.RequiredOrOptional, len(dst))
7070
for i := range dst {
7171
values[i] = &valuer{}

0 commit comments

Comments
 (0)