Fixed mutable behaviour of tx.WithCommit()

Author: asmyasnikov

CHANGELOG.md

@@ -1,6 +1,7 @@
 * Added retry policy options for topics: `topic/topicoptions.WithReaderCheckRetryErrorFunction`, `topic/topicoptions.WithReaderStartTimeout`, `topic/topicoptions.WithWriterCheckRetryErrorFunction`, `topic/topicoptions.WithWriterStartTimeout`
 * Refactored `internal/conn` middlewares for `DRY`
 * Added `trace.tableSessionInfo.LastUsage()` method for get last usage timestamp
+* Fixed mutable behaviour of `tx.WithCommit()`
 
 ## v3.41.0
 * Added option for set interval of auth token update in topic streams

internal/table/transaction.go

@@ -119,8 +119,12 @@ func (tx *transaction) ExecuteStatement(
 }
 
 func (tx *transaction) WithCommit() table.TransactionActor {
-	tx.c = tx.c.With(table.CommitTx())
-	return tx
+	return &transaction{
+		id:        tx.id,
+		s:         tx.s,
+		c:         table.TxControl(table.WithTxID(tx.id), table.CommitTx()),
+		committed: tx.committed,
+	}
 }
 
 // CommitTx commits specified active transaction.

table/table.go

@@ -247,9 +247,7 @@ type Transaction interface {
 		ctx context.Context,
 	) (err error)
 
-	// WithCommit modifies current transaction with add flag for auto-commit on next Execute[Statement] query
-	//
-	// Current transaction will set to committed state after next execute query
+	// WithCommit returns transaction actor which contains auto-commit flag in next Execute[Statement] query
 	WithCommit() TransactionActor
 }
 
@@ -381,14 +379,6 @@ func (t *TransactionControl) Desc() *Ydb_Table.TransactionControl {
 	return &t.desc
 }
 
-// With modifies current TransactionControl with options
-func (t *TransactionControl) With(opts ...TxControlOption) *TransactionControl {
-	for _, opt := range opts {
-		opt((*txControlDesc)(&t.desc))
-	}
-	return t
-}
-
 // TxControl makes transaction control from given options
 func TxControl(opts ...TxControlOption) *TransactionControl {
 	c := new(TransactionControl)