Skip to content

Commit 6dbf00e

Browse files
committed
fix typecheck issues
1 parent 81caf5d commit 6dbf00e

File tree

4 files changed

+9
-6
lines changed

4 files changed

+9
-6
lines changed

.github/workflows/lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,4 +17,4 @@ jobs:
1717
- name: golangci-lint
1818
uses: golangci/golangci-lint-action@v2
1919
with:
20-
version: v1.39
20+
version: v1.45.2

internal/cmd/gtrace/main.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,8 @@ func main() {
6969
openFile := func(name string) (*os.File, func()) {
7070
p := filepath.Join(workDir, name)
7171
var f *os.File
72+
// nolint: gofumpt
73+
// nolint: nolintlint
7274
f, err = os.OpenFile(p, os.O_WRONLY|os.O_CREATE|os.O_TRUNC, 0666)
7375
if err != nil {
7476
log.Fatal(err)

table/options/models.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -446,12 +446,14 @@ type TTLSettings struct {
446446
type TimeToLiveSettings struct {
447447
ColumnName string
448448

449-
// Specifies mode
450-
Mode TimeToLiveMode
451-
ExpireAfterSeconds uint32
449+
// Mode specified mode
450+
Mode TimeToLiveMode
452451

453-
ColumnUnit *TimeToLiveUnit // valid with Mode = TimeToLiveModeValueSinceUnixEpoch
452+
// ExpireAfterSeconds specified expiration in seconds
453+
ExpireAfterSeconds uint32
454454

455+
// ColumnUnit valid with Mode = TimeToLiveModeValueSinceUnixEpoch
456+
ColumnUnit *TimeToLiveUnit
455457
}
456458

457459
type TimeToLiveMode byte

table/result/result.go

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,6 @@ import (
3030
// is not requested types, then res.err() become non-nil.
3131
// After that, NextResultSet(), NextRow() will return false.
3232
type result interface {
33-
3433
// HasNextResultSet reports whether result set may be advanced.
3534
// It may be useful to call HasNextResultSet() instead of NextResultSet() to look ahead
3635
// without advancing the result set.

0 commit comments

Comments
 (0)