fix

Author: asmyasnikov

internal/pool/pool.go

@@ -129,7 +129,7 @@ func defaultCreateItem[T any, PT Item[T]](context.Context) (PT, error) {
 }
 
 // makeCreateItemFunc wraps the createItem function with timeout handling
-func makeCreateItemFunc[PT Item[T], T any](
+func makeCreateItemFunc[PT Item[T], T any]( //nolint:funlen
 	config Config[PT, T],
 	done <-chan struct{},
 	appendToIdle func(item PT) error,
@@ -206,6 +206,9 @@ func (p *Pool[PT, T]) onChangeStats() {
 }
 
 func (p *Pool[PT, T]) Stats() Stats {
+	p.mu.RLock()
+	defer p.mu.RUnlock()
+
 	return Stats{
 		Limit: p.config.limit,
 		Idle:  len(p.idle),
@@ -301,7 +304,10 @@ func (p *Pool[PT, T]) putItem(ctx context.Context, item PT) (finalErr error) {
 	}
 }
 
-func makeAsyncCloseItemFunc[PT Item[T], T any](closeTimeout time.Duration, done <-chan struct{}) func(ctx context.Context, item PT) {
+func makeAsyncCloseItemFunc[PT Item[T], T any](
+	closeTimeout time.Duration,
+	done <-chan struct{},
+) func(ctx context.Context, item PT) {
 	return func(ctx context.Context, item PT) {
 		closeItemCtx, closeItemCancel := xcontext.WithDone(xcontext.ValueOnly(ctx), done)
 		defer closeItemCancel()

internal/xsync/mutex.go

@@ -33,20 +33,25 @@ func (l *RWMutex) WithRLock(f func()) {
 	f()
 }
 
-func WithLock[T any](l interface {
-	Lock()
-	Unlock()
-}, f func() T) T {
+type (
+	mutex interface {
+		Lock()
+		Unlock()
+	}
+	rwMutex interface {
+		RLock()
+		RUnlock()
+	}
+)
+
+func WithLock[T any](l mutex, f func() T) T {
 	l.Lock()
 	defer l.Unlock()
 
 	return f()
 }
 
-func WithRLock[T any](l interface {
-	RLock()
-	RUnlock()
-}, f func() T) T {
+func WithRLock[T any](l rwMutex, f func() T) T {
 	l.RLock()
 	defer l.RUnlock()
 

internal/xsync/mutex_test.go

@@ -123,14 +123,14 @@ func TestWithLock(t *testing.T) {
 func TestWithRLock(t *testing.T) {
 	t.Run("sync.RWMutex", func(t *testing.T) {
 		mtx := sync.RWMutex{}
-		v := WithLock(&mtx, func() int {
+		v := WithRLock(&mtx, func() int {
 			return 123
 		})
 		require.Equal(t, 123, v)
 	})
 	t.Run("xsync.RWMutex", func(t *testing.T) {
 		mtx := RWMutex{}
-		v := WithLock(&mtx, func() int {
+		v := WithRLock(&mtx, func() int {
 			return 123
 		})
 		require.Equal(t, 123, v)

internal/xsync/set.go

@@ -40,7 +40,7 @@ func (s *Set[T]) Values() []T {
 	values := make([]T, 0, s.size.Load())
 
 	s.m.Range(func(k, v any) bool {
-		values = append(values, k.(T))
+		values = append(values, k.(T)) //nolint:forcetypeassert
 
 		return true
 	})