fix good states for balancer

rekby · rekby · commit 779bc9478d96 · 2022-04-20T15:32:25.000+03:00
diff --git a/internal/balancer/rr/rr.go b/internal/balancer/rr/rr.go
@@ -141,12 +141,12 @@ func (r *randomChoice) Next() conn.Conn {
 }
 
 func isOkConnection(c conn.Conn, bannedIsOk bool) bool {
-	state := c.GetState()
-	if state == conn.Online || state == conn.Created {
-		return true
-	}
-	if bannedIsOk && state == conn.Banned {
+	switch c.GetState() {
+	case conn.Online, conn.Created, conn.Offline:
 		return true
+	case conn.Banned:
+		return bannedIsOk
+	default:
+		return false
 	}
-	return false
 }

Original file line number	Diff line number	Diff line change
`@@ -141,12 +141,12 @@ func (r *randomChoice) Next() conn.Conn {`
`141`	`141`	`}`
`142`	`142`
`143`	`143`	`func isOkConnection(c conn.Conn, bannedIsOk bool) bool {`
`144`		`- state := c.GetState()`
`145`		`- if state == conn.Online \|\| state == conn.Created {`
`146`		`- return true`
`147`		`- }`
`148`		`- if bannedIsOk && state == conn.Banned {`
	`144`	`+ switch c.GetState() {`
	`145`	`+ case conn.Online, conn.Created, conn.Offline:`
`149`	`146`	`return true`
	`147`	`+ case conn.Banned:`
	`148`	`+ return bannedIsOk`
	`149`	`+ default:`
	`150`	`+ return false`
`150`	`151`	`}`
`151`		`- return false`
`152`	`152`	`}`