Merge pull request #1436 from laskoviymishka/fix-1435

feat: expose `DecimalValueFromString`

Author: asmyasnikov

CHANGELOG.md

@@ -1,3 +1,5 @@
+* Added `table/types.DecimalValueFromString` decimal type constructor
+
 ## v3.77.1
 * Added log topic writer ack
 * Replaced `operation.Client.List` to five methods for listing operations `operation.List{BuildIndex,ImportFromS3,ExportToS3,ExportToYT,ExecuteQuery}`

examples/decimal/main.go

@@ -93,6 +93,10 @@ func main() {
 
 			x := big.NewInt(42 * 1000000000)
 			x.Mul(x, big.NewInt(2))
+			parsedDecimal, err := types.DecimalValueFromString("42.00", 22, 9)
+			if err != nil {
+				panic(err)
+			}
 
 			_, _, err = s.Execute(ctx, txc, render(writeQuery, templateConfig{
 				TablePathPrefix: prefix,
@@ -103,6 +107,10 @@ func main() {
 							types.StructFieldValue("id", types.Uint32Value(42)),
 							types.StructFieldValue("value", types.DecimalValueFromBigInt(x, 22, 9)),
 						),
+						types.StructValue(
+							types.StructFieldValue("id", types.Uint32Value(43)),
+							types.StructFieldValue("value", parsedDecimal),
+						),
 					),
 				),
 			))

table/types/cast_test.go

@@ -2,6 +2,7 @@ package types
 
 import (
 	"math/big"
+	"strconv"
 	"testing"
 
 	"github.com/stretchr/testify/require"
@@ -87,3 +88,32 @@ func TestToDecimal(t *testing.T) {
 		})
 	}
 }
+
+func TestDecimalParse(t *testing.T) {
+	for i, tt := range []struct {
+		raw     string
+		literal string
+		err     bool
+	}{
+		{
+			raw:     "-1234567.890123456",
+			literal: `Decimal("-1234567.890123456",22,9)`,
+			err:     false,
+		},
+		{
+			raw:     "not a decimal",
+			literal: ``,
+			err:     true,
+		},
+	} {
+		t.Run(strconv.Itoa(i)+"."+tt.raw, func(t *testing.T) {
+			dec, err := DecimalValueFromString(tt.raw, 22, 9)
+			if err != nil {
+				require.True(t, tt.err)
+				require.Nil(t, dec)
+			} else {
+				require.Equal(t, tt.literal, dec.Yql())
+			}
+		})
+	}
+}

table/types/value.go

@@ -189,6 +189,15 @@ func DecimalValueFromBigInt(v *big.Int, precision, scale uint32) Value {
 	return value.DecimalValueFromBigInt(v, precision, scale)
 }
 
+func DecimalValueFromString(str string, precision, scale uint32) (Value, error) {
+	bigI, err := decimal.Parse(str, precision, scale)
+	if err != nil {
+		return nil, err
+	}
+
+	return value.DecimalValueFromBigInt(bigI, precision, scale), nil
+}
+
 func TupleValue(vs ...Value) Value {
 	return value.TupleValue(vs...)
 }