Skip to content

Commit 80db1c5

Browse files
authored
Merge pull request #1725 from ydb-platform/ignore-delay-on-sync-commit
Ignore delay before sync commit
2 parents d58c87c + 89a6cfb commit 80db1c5

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
* Removed delay before send commit in sync mode of a topic reader
2+
13
## v3.105.2
24
* Improved the `ydb.WithSessionPoolSessionUsageLimit` option for allow `time.Duration` as argument type for limit max session time to live since create time
35

internal/topic/topicreadercommon/committer.go

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,13 @@ func (c *Committer) waitSendTrigger(ctx context.Context) {
167167
case <-c.commitLoopSignal:
168168
}
169169

170+
// In sync mode, ignore time lag trigger and send immediately,
171+
// because we need to wait for commit ack from the server and can't get
172+
// more commit messages until the ack is received.
173+
if c.mode == CommitModeSync {
174+
return
175+
}
176+
170177
if c.BufferTimeLagTrigger == 0 {
171178
return
172179
}

0 commit comments

Comments
 (0)