Skip to content

Commit 8616284

Browse files
authored
Merge pull request #1474 from ydb-platform/fix-tests
fix tests + added integration tests for YDB 24.2
2 parents 1a5e570 + 613f294 commit 8616284

File tree

2 files changed

+3
-11
lines changed

2 files changed

+3
-11
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ jobs:
5151
fail-fast: false
5252
matrix:
5353
go-version: [1.21.x, 1.22.x, 1.23.x]
54-
ydb-version: [23.3, 24.1]
54+
ydb-version: [23.3, 24.1, 24.2]
5555
os: [ubuntu]
5656
services:
5757
ydb:

tests/integration/query_tx_execute_test.go

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -200,11 +200,7 @@ func TestQueryTxExecute(t *testing.T) {
200200
}
201201
return nil
202202
}, query.WithIdempotent(), query.WithTxSettings(query.TxSettings(query.WithOnlineReadOnly())))
203-
if version.Lt(os.Getenv("YDB_VERSION"), "24.3") {
204-
require.NoError(t, err)
205-
} else {
206-
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
207-
}
203+
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
208204
})
209205
t.Run("StaleReadOnly", func(t *testing.T) {
210206
err := scope.DriverWithLogs().Query().DoTx(scope.Ctx, func(ctx context.Context, tx query.TxActor) (err error) {
@@ -227,11 +223,7 @@ func TestQueryTxExecute(t *testing.T) {
227223
}
228224
return nil
229225
}, query.WithIdempotent(), query.WithTxSettings(query.TxSettings(query.WithStaleReadOnly())))
230-
if version.Lt(os.Getenv("YDB_VERSION"), "24.3") {
231-
require.NoError(t, err)
232-
} else {
233-
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
234-
}
226+
require.True(t, ydb.IsOperationError(err, Ydb.StatusIds_BAD_REQUEST))
235227
})
236228
t.Run("ErrOptionNotForTxExecute", func(t *testing.T) {
237229
err := scope.DriverWithLogs().Query().DoTx(scope.Ctx, func(ctx context.Context, tx query.TxActor) (err error) {

0 commit comments

Comments
 (0)