Added stacktrace to errors with issues

Author: asmyasnikov

CHANGELOG.md

@@ -1,3 +1,5 @@
+* Added stacktrace to errors with issues
+
 ## v3.16.10
 * Refactored `cluster.Cluster` and `balancer.Balancer` interfaces (removed `Update` method)
 * Replaced `cluster.Update` with `cluster.Remove` and `cluster.Insert` calls

internal/cluster/cluster.go

@@ -239,7 +239,7 @@ func (c *cluster) Close(ctx context.Context) (err error) {
 	}
 
 	if len(issues) > 0 {
-		return errors.NewWithIssues("cluster closed with issues", issues...)
+		return errors.WithStackTrace(errors.NewWithIssues("cluster closed with issues", issues...))
 	}
 
 	return nil

internal/conn/conn.go

@@ -80,7 +80,7 @@ func (c *conn) Release(ctx context.Context) (err error) {
 	}
 
 	if len(issues) > 0 {
-		return errors.NewWithIssues("conn released with issues", issues...)
+		return errors.WithStackTrace(errors.NewWithIssues("conn released with issues", issues...))
 	}
 
 	return nil

internal/table/client.go

@@ -495,10 +495,7 @@ func (c *client) Close(ctx context.Context) (err error) {
 	c.wgClosed.Wait()
 
 	if len(issues) > 0 {
-		return errors.WithStackTrace(errors.NewWithIssues(
-			"table client closed with issues",
-			issues...,
-		))
+		return errors.WithStackTrace(errors.NewWithIssues("table client closed with issues", issues...))
 	}
 
 	return nil

options.go

@@ -86,10 +86,13 @@ func WithConnectionString(connectionString string) Option {
 			}
 			issues = append(issues, err)
 		}
-		return errors.NewWithIssues(
-			"parse connection string '"+connectionString+"' failed:",
-			issues...,
-		)
+		if len(issues) > 0 {
+			return errors.WithStackTrace(errors.NewWithIssues(
+				"parse connection string '"+connectionString+"' failed:",
+				issues...,
+			))
+		}
+		return nil
 	}
 }