Merge pull request #1464 from ydb-platform/pool-leak

asmyasnikov · web-flow · commit 89a10b01166d · 2024-09-16T17:36:17.000+03:00
* Fixed connections pool leak on failed `ydb.Open` call
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Fixed connections pool leak on failed `ydb.Open` call
+
 ## v3.80.4
 * Fixed panic on usage metrics package from prometheus adapter on `trace.Driver.OnNewStream` callback
 
diff --git a/driver.go b/driver.go
@@ -274,6 +274,8 @@ func Open(ctx context.Context, dsn string, opts ...Option) (_ *Driver, _ error)
 	}()
 
 	if err = d.connect(ctx); err != nil {
+		_ = d.pool.Release(ctx)
+
 		return nil, xerrors.WithStackTrace(err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	+* Fixed connections pool leak on failed `ydb.Open` call
	`2`	`+`
`1`	`3`	`## v3.80.4`
`2`	`4`	* Fixed panic on usage metrics package from prometheus adapter on `trace.Driver.OnNewStream` callback
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -274,6 +274,8 @@ func Open(ctx context.Context, dsn string, opts ...Option) (_ *Driver, _ error)`
`274`	`274`	`}()`
`275`	`275`
`276`	`276`	`if err = d.connect(ctx); err != nil {`
	`277`	`+ _ = d.pool.Release(ctx)`
	`278`	`+`
`277`	`279`	`return nil, xerrors.WithStackTrace(err)`
`278`	`280`	`}`
`279`	`281`