test(slo): add table path prefixes

Author: ImpressionableRaccoon

.github/workflows/slo.yml

@@ -10,8 +10,7 @@ jobs:
   native:
     concurrency:
       group: slo-native-${{ github.ref }}
-    if: github.event.pull_request.head.repo.full_name == 'ydb-platform/ydb-go-sdk' &&
-      !contains(github.event.pull_request.labels.*.name, 'no slo')
+    if: (!contains(github.event.pull_request.labels.*.name, 'no slo'))
     uses: ydb-platform/slo-tests/.github/workflows/slo.yml@main
     secrets: inherit
     with:
@@ -24,8 +23,7 @@ jobs:
     needs: [native]
     concurrency:
       group: slo-database-sql-${{ github.ref }}
-    if: github.event.pull_request.head.repo.full_name == 'ydb-platform/ydb-go-sdk' &&
-      !contains(github.event.pull_request.labels.*.name, 'no slo')
+    if: always() && !contains(github.event.pull_request.labels.*.name, 'no slo')
     uses: ydb-platform/slo-tests/.github/workflows/slo.yml@main
     secrets: inherit
     with:
@@ -38,8 +36,7 @@ jobs:
     needs: [database_sql]
     concurrency:
       group: slo-gorm-${{ github.ref }}
-    if: github.event.pull_request.head.repo.full_name == 'ydb-platform/ydb-go-sdk' &&
-      !contains(github.event.pull_request.labels.*.name, 'no slo')
+    if: always() && !contains(github.event.pull_request.labels.*.name, 'no slo')
     uses: ydb-platform/slo-tests/.github/workflows/slo.yml@main
     secrets: inherit
     with:

tests/slo/database/sql/storage.go

@@ -4,6 +4,7 @@ import (
 	"context"
 	"database/sql"
 	"fmt"
+	"path"
 	"time"
 
 	env "github.com/ydb-platform/ydb-go-sdk-auth-environ"
@@ -104,6 +105,7 @@ func NewStorage(ctx context.Context, cfg *config.Config, poolSize int) (s *Stora
 
 	s.c, err = ydb.Connector(s.cc,
 		ydb.WithAutoDeclare(),
+		ydb.WithTablePathPrefix(path.Join(s.cc.Name(), label)),
 	)
 	if err != nil {
 		return nil, fmt.Errorf("ydb.Connector error: %w", err)

tests/slo/gorm/storage.go

@@ -80,9 +80,10 @@ func NewStorage(ctx context.Context, cfg *config.Config, poolSize int) (*Storage
 			),
 			ydb.WithMaxOpenConns(poolSize),
 			ydb.WithMaxIdleConns(poolSize),
+			ydb.WithTablePathPrefix(label),
 		),
 		&gorm.Config{
-			Logger: gormLogger.Default.LogMode(gormLogger.Info),
+			Logger: gormLogger.Default.LogMode(gormLogger.Warn),
 		},
 	)
 	if err != nil {

tests/slo/internal/metrics/metrics.go

@@ -18,12 +18,11 @@ const (
 
 type (
 	Metrics struct {
-		oks        *prometheus.GaugeVec
-		notOks     *prometheus.GaugeVec
-		inflight   *prometheus.GaugeVec
-		latencies  *prometheus.SummaryVec
-		latenciesH *prometheus.HistogramVec
-		attempts   *prometheus.HistogramVec
+		oks       *prometheus.GaugeVec
+		notOks    *prometheus.GaugeVec
+		inflight  *prometheus.GaugeVec
+		latencies *prometheus.SummaryVec
+		attempts  *prometheus.HistogramVec
 
 		p *push.Pusher
 
@@ -66,22 +65,14 @@ func New(logger *zap.Logger, url, label string) (*Metrics, error) {
 			Name: "latency",
 			Help: "summary of latencies in ms",
 			Objectives: map[float64]float64{
-				0.5:  0.05,
-				0.99: 0.001,
-				1.0:  0.0,
+				0.5:  0,
+				0.99: 0,
+				1.0:  0,
 			},
 			MaxAge: 15 * time.Second,
 		},
 		[]string{"status", "jobName"},
 	)
-	m.latenciesH = prometheus.NewHistogramVec(
-		prometheus.HistogramOpts{
-			Name:    "latencyH",
-			Help:    "latencies in ms",
-			Buckets: []float64{1, 2, 5, 10, 20, 50, 100, 200, 400, 800, 1600, 3200, 6400},
-		},
-		[]string{"status", "jobName"},
-	)
 	m.attempts = prometheus.NewHistogramVec(
 		prometheus.HistogramOpts{
 			Name:    "attempts",
@@ -98,7 +89,6 @@ func New(logger *zap.Logger, url, label string) (*Metrics, error) {
 		Collector(m.notOks).
 		Collector(m.inflight).
 		Collector(m.latencies).
-		Collector(m.latenciesH).
 		Collector(m.attempts)
 
 	return m, m.Reset() //nolint:gocritic
@@ -119,7 +109,6 @@ func (m *Metrics) Reset() error {
 	m.inflight.WithLabelValues(JobWrite).Set(0)
 
 	m.latencies.Reset()
-	m.latenciesH.Reset()
 
 	m.attempts.Reset()
 
@@ -158,13 +147,11 @@ func (j Span) Stop(err error, attempts int) {
 	if err != nil {
 		j.m.notOks.WithLabelValues(j.name).Add(1)
 		j.m.latencies.WithLabelValues(JobStatusErr, j.name).Observe(latency)
-		j.m.latenciesH.WithLabelValues(JobStatusErr, j.name).Observe(latency)
 		j.m.attempts.WithLabelValues(JobStatusErr, j.name).Observe(float64(attempts))
 		return
 	}
 
 	j.m.oks.WithLabelValues(j.name).Add(1)
 	j.m.latencies.WithLabelValues(JobStatusOK, j.name).Observe(latency)
-	j.m.latenciesH.WithLabelValues(JobStatusOK, j.name).Observe(latency)
 	j.m.attempts.WithLabelValues(JobStatusOK, j.name).Observe(float64(attempts))
 }

tests/slo/native/storage.go

@@ -22,17 +22,22 @@ import (
 
 const (
 	upsertTemplate = `
+PRAGMA TablePathPrefix("%s");
+
 DECLARE $id AS Uint64;
 DECLARE $payload_str AS Utf8;
 DECLARE $payload_double AS Double;
 DECLARE $payload_timestamp AS Timestamp;
+
 UPSERT INTO %s (
 	id, hash, payload_str, payload_double, payload_timestamp
 ) VALUES (
 	$id, Digest::NumericHash($id), $payload_str, $payload_double, $payload_timestamp
 );
 `
 	selectTemplate = `
+PRAGMA TablePathPrefix("%s");
+
 DECLARE $id AS Uint64;
 SELECT id, payload_str, payload_double, payload_timestamp, payload_hash
 FROM %s WHERE id = $id AND hash = Digest::NumericHash($id);
@@ -55,6 +60,7 @@ var (
 type Storage struct {
 	db          *ydb.Driver
 	cfg         *config.Config
+	prefix      string
 	upsertQuery string
 	selectQuery string
 }
@@ -63,15 +69,9 @@ func NewStorage(ctx context.Context, cfg *config.Config, poolSize int) (*Storage
 	ctx, cancel := context.WithTimeout(ctx, time.Minute*5)
 	defer cancel()
 
-	s := &Storage{
-		cfg:         cfg,
-		upsertQuery: fmt.Sprintf(upsertTemplate, cfg.Table),
-		selectQuery: fmt.Sprintf(selectTemplate, cfg.Table),
-	}
-	var err error
-	s.db, err = ydb.Open(
+	db, err := ydb.Open(
 		ctx,
-		s.cfg.Endpoint+s.cfg.DB,
+		cfg.Endpoint+cfg.DB,
 		env.WithEnvironCredentials(ctx),
 		ydbZap.WithTraces(
 			logger,
@@ -83,6 +83,16 @@ func NewStorage(ctx context.Context, cfg *config.Config, poolSize int) (*Storage
 		return nil, err
 	}
 
+	prefix := path.Join(db.Name(), label)
+
+	s := &Storage{
+		db:          db,
+		cfg:         cfg,
+		prefix:      prefix,
+		upsertQuery: fmt.Sprintf(upsertTemplate, prefix, cfg.Table),
+		selectQuery: fmt.Sprintf(selectTemplate, prefix, cfg.Table),
+	}
+
 	return s, nil
 }
 
@@ -201,7 +211,7 @@ func (s *Storage) createTable(ctx context.Context) error {
 
 	return s.db.Table().Do(ctx,
 		func(ctx context.Context, session table.Session) error {
-			return session.CreateTable(ctx, path.Join(s.db.Name(), s.cfg.Table),
+			return session.CreateTable(ctx, path.Join(s.prefix, s.cfg.Table),
 				options.WithColumn("hash", types.Optional(types.TypeUint64)),
 				options.WithColumn("id", types.Optional(types.TypeUint64)),
 				options.WithColumn("payload_str", types.Optional(types.TypeUTF8)),
@@ -234,7 +244,7 @@ func (s *Storage) dropTable(ctx context.Context) error {
 
 	return s.db.Table().Do(ctx,
 		func(ctx context.Context, session table.Session) (err error) {
-			return session.DropTable(ctx, path.Join(s.db.Name(), s.cfg.Table))
+			return session.DropTable(ctx, path.Join(s.prefix, s.cfg.Table))
 		},
 		table.WithIdempotent(),
 	)