Merge pull request #1645 check stats exists before callback stat within newResult

rekby · web-flow · commit 9bcc808a2ea1 · 2025-02-11T20:42:37.000+03:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Fixed sometime panic on stats receive in query service
+
 ## v3.99.7
 * Fixed not passing request context to topic event logs
 * Fixed deadlock on closing table session with internal query session core
diff --git a/internal/query/result.go b/internal/query/result.go
@@ -169,7 +169,7 @@ func newResult(
 
 		r.lastPart = part
 
-		if r.statsCallback != nil {
+		if part.GetExecStats() != nil && r.statsCallback != nil {
 			r.statsCallback(stats.FromQueryStats(part.GetExecStats()))
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+* Fixed sometime panic on stats receive in query service`
	`2`	`+`
`1`	`3`	`## v3.99.7`
`2`	`4`	`* Fixed not passing request context to topic event logs`
`3`	`5`	`* Fixed deadlock on closing table session with internal query session core`
Original file line number	Diff line number	Diff line change
`@@ -169,7 +169,7 @@ func newResult(`
`169`	`169`
`170`	`170`	`r.lastPart = part`
`171`	`171`
`172`		`- if r.statsCallback != nil {`
	`172`	`+ if part.GetExecStats() != nil && r.statsCallback != nil {`
`173`	`173`	`r.statsCallback(stats.FromQueryStats(part.GetExecStats()))`
`174`	`174`	`}`
`175`	`175`