Merge pull request #756 from ydb-platform/754-retry-eof

Mark io.EOF error as retriable for topic

Author: asmyasnikov

CHANGELOG.md

@@ -1,3 +1,4 @@
+* Fixed stopping topic reader by grpc stream shutdown
 * Fixed `database/sql` driver for get and parse container ydb types
 * Changed `table/scanner.scanner.Any()` behaviour: for non-primitive types returns raw `table/types.Value` instead nil from previous behaviour
 * Added `table/types.{ListItems,VariantValue,DictValues}` helpers for get internal content of abstract `table/types.Value`

internal/topic/retriable_error.go

@@ -1,10 +1,13 @@
 package topic
 
 import (
+	"errors"
 	"fmt"
+	"io"
 	"time"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/backoff"
+	"github.com/ydb-platform/ydb-go-sdk/v3/internal/xerrors"
 	"github.com/ydb-platform/ydb-go-sdk/v3/retry"
 )
 
@@ -53,6 +56,11 @@ func CheckRetryMode(err error, settings RetrySettings, retriesDuration time.Dura
 		return nil, false
 	}
 
+	// eof is retriable for topic
+	if errors.Is(err, io.EOF) && xerrors.RetryableError(err) == nil {
+		err = xerrors.Retryable(err, xerrors.WithName("TopicEOF"))
+	}
+
 	if retriesDuration > settings.StartTimeout {
 		return nil, false
 	}

internal/topic/retriable_error_test.go

@@ -1,6 +1,8 @@
 package topic
 
 import (
+	"fmt"
+	"io"
 	"testing"
 	"time"
 
@@ -212,6 +214,14 @@ func TestCheckRetryMode(t *testing.T) {
 			resBackoff:   nil,
 			resRetriable: false,
 		},
+		{
+			name:         "EOF", // Issue https://github.com/ydb-platform/ydb-go-sdk/issues/754
+			err:          fmt.Errorf("test wrap: %w", io.EOF),
+			settings:     RetrySettings{},
+			duration:     0,
+			resBackoff:   backoff.Slow,
+			resRetriable: true,
+		},
 	}
 
 	for _, test := range table {