Merge pull request #1014 from v1tbrah/issues/863/StatusIds_SESSION_EXPIRED-is-non-retriable

asmyasnikov · web-flow · commit a4cc963f3d6f · 2024-01-26T00:05:13.000+03:00
fix: Make the error StatusIds_SESSION_EXPIRED retriable
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Made `StatusIds_SESSION_EXPIRED` retriable for idempotent operations
+
 ## v3.55.0
 * Refactored `internal/value/intervalValue.Yql()`
 * The minimum version of Go in `ydb-go-sdk` has been raised to `go1.20`
diff --git a/internal/xerrors/operation.go b/internal/xerrors/operation.go
@@ -166,7 +166,9 @@ func (e *operationError) Type() Type {
 		Ydb.StatusIds_BAD_SESSION,
 		Ydb.StatusIds_SESSION_BUSY:
 		return TypeRetryable
-	case Ydb.StatusIds_UNDETERMINED:
+	case
+		Ydb.StatusIds_UNDETERMINED,
+		Ydb.StatusIds_SESSION_EXPIRED:
 		return TypeConditionallyRetryable
 	default:
 		return TypeUndefined
diff --git a/retry/errors_data_test.go b/retry/errors_data_test.go
@@ -408,7 +408,7 @@ var errsToCheck = []struct {
 		backoff:       backoff.TypeNoBackoff,
 		deleteSession: true,
 		canRetry: map[idempotency]bool{
-			idempotent:    false,
+			idempotent:    true,
 			nonIdempotent: false,
 		},
 	},

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	+* Made `StatusIds_SESSION_EXPIRED` retriable for idempotent operations
	`2`	`+`
`1`	`3`	`## v3.55.0`
`2`	`4`	* Refactored `internal/value/intervalValue.Yql()`
`3`	`5`	* The minimum version of Go in `ydb-go-sdk` has been raised to `go1.20`