Merge pull request #1699 from hurd54/fix-query-session-latency-metrics

asmyasnikov · web-flow · commit a5cbece7085d · 2025-03-18T10:37:55.000+03:00
Fixed bug with session query latency metric collector
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Fixed bug with session query latency metric collector
+
 ## v3.104.3
 * Changed argument types in `table.Client.ReadRows` to public types for compatibility with mock-generation 
 
diff --git a/metrics/query.go b/metrics/query.go
@@ -251,7 +251,7 @@ func query(config Config) (t trace.Query) {
 		{
 			sessionQueryConfig := sessionConfig.WithSystem("query")
 			errs := sessionQueryConfig.CounterVec("errs", "status", "label")
-			latency := sessionQueryConfig.TimerVec("latency")
+			latency := sessionQueryConfig.TimerVec("latency", "label")
 			t.OnSessionQuery = func(info trace.QuerySessionQueryStartInfo) func(trace.QuerySessionQueryDoneInfo) {
 				start := time.Now()
 				label := info.Label

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+* Fixed bug with session query latency metric collector`
	`2`	`+`
`1`	`3`	`## v3.104.3`
`2`	`4`	* Changed argument types in `table.Client.ReadRows` to public types for compatibility with mock-generation
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -251,7 +251,7 @@ func query(config Config) (t trace.Query) {`
`251`	`251`	`{`
`252`	`252`	`sessionQueryConfig := sessionConfig.WithSystem("query")`
`253`	`253`	`errs := sessionQueryConfig.CounterVec("errs", "status", "label")`
`254`		`- latency := sessionQueryConfig.TimerVec("latency")`
	`254`	`+ latency := sessionQueryConfig.TimerVec("latency", "label")`
`255`	`255`	`t.OnSessionQuery = func(info trace.QuerySessionQueryStartInfo) func(trace.QuerySessionQueryDoneInfo) {`
`256`	`256`	`start := time.Now()`
`257`	`257`	`label := info.Label`