added tests for raw ydb value

Author: asmyasnikov

internal/types/types.go

@@ -966,11 +966,13 @@ type protobufType struct {
 }
 
 func (v protobufType) Yql() string {
-	return fmt.Sprintf("protobufType(%s)", v.pb.String())
+	return FromYDB([]*Ydb.Type{
+		v.pb,
+	})[0].Yql()
 }
 
 func (v protobufType) String() string {
-	return fmt.Sprintf("protobufType(%s)", v.pb.String())
+	return v.Yql()
 }
 
 func (v protobufType) ToYDB(a *allocator.Allocator) *Ydb.Type {

internal/types/types_test.go

@@ -4,6 +4,7 @@ import (
 	"testing"
 
 	"github.com/stretchr/testify/require"
+	"github.com/ydb-platform/ydb-go-genproto/protos/Ydb"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/pg"
 )
@@ -273,11 +274,40 @@ func TestTypeToString(t *testing.T) {
 			t: PgType{OID: pg.OIDUnknown},
 			s: "PgType(705)",
 		},
+		{
+			t: FromProtobuf(&Ydb.Type{
+				Type: &Ydb.Type_VariantType{
+					VariantType: &Ydb.VariantType{
+						Type: &Ydb.VariantType_StructItems{
+							StructItems: &Ydb.StructType{
+								Members: []*Ydb.StructMember{
+									{
+										Name: "a",
+										Type: &Ydb.Type{
+											Type: &Ydb.Type_TypeId{
+												TypeId: Ydb.Type_BOOL,
+											},
+										},
+									},
+									{
+										Name: "a",
+										Type: &Ydb.Type{
+											Type: &Ydb.Type_TypeId{
+												TypeId: Ydb.Type_FLOAT,
+											},
+										},
+									},
+								},
+							},
+						},
+					},
+				},
+			}),
+			s: "Variant<'a':Bool,'a':Float>",
+		},
 	} {
 		t.Run(tt.s, func(t *testing.T) {
-			if got := tt.t.Yql(); got != tt.s {
-				t.Errorf("s representations not equals:\n\n -  got: %s\n\n - want: %s", got, tt.s)
-			}
+			require.Equal(t, tt.s, tt.t.Yql())
 		})
 	}
 }

internal/value/value.go

@@ -2776,7 +2776,7 @@ func (v protobufValue) Type() types.Type {
 }
 
 func (v protobufValue) Yql() string {
-	return fmt.Sprintf("protobufValue(%s)", v.pb.String())
+	return FromYDB(v.pb.GetType(), v.pb.GetValue()).Yql()
 }
 
 func (v protobufValue) castTo(dst any) error {

internal/value/value_test.go

@@ -10,6 +10,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/require"
+	"github.com/ydb-platform/ydb-go-genproto/protos/Ydb"
 	"google.golang.org/protobuf/proto"
 
 	"github.com/ydb-platform/ydb-go-sdk/v3/internal/allocator"
@@ -504,8 +505,67 @@ func TestValueYql(t *testing.T) {
 			value:   PgValue(pg.OIDUnknown, "123"),
 			literal: `PgConst("123", PgType(705))`,
 		},
+		{
+			value: FromProtobuf(&Ydb.TypedValue{
+				Type: &Ydb.Type{
+					Type: &Ydb.Type_TupleType{
+						TupleType: &Ydb.TupleType{
+							Elements: []*Ydb.Type{
+								{
+									Type: &Ydb.Type_TypeId{
+										TypeId: Ydb.Type_INT32,
+									},
+								},
+								{
+									Type: &Ydb.Type_TypeId{
+										TypeId: Ydb.Type_INT64,
+									},
+								},
+								{
+									Type: &Ydb.Type_TypeId{
+										TypeId: Ydb.Type_FLOAT,
+									},
+								},
+								{
+									Type: &Ydb.Type_TypeId{
+										TypeId: Ydb.Type_UTF8,
+									},
+								},
+							},
+						},
+					},
+				},
+				Value: &Ydb.Value{
+					Items: []*Ydb.Value{
+						{
+							Value: &Ydb.Value_Int32Value{
+								Int32Value: 0,
+							},
+						},
+						{
+							Value: &Ydb.Value_Int64Value{
+								Int64Value: 1,
+							},
+						},
+						{
+							Value: &Ydb.Value_FloatValue{
+								FloatValue: 2,
+							},
+						},
+						{
+							Value: &Ydb.Value_TextValue{
+								TextValue: "3",
+							},
+						},
+					},
+				},
+			}),
+			literal: `(0,1l,Float("2"),"3"u)`,
+		},
 	} {
 		t.Run(strconv.Itoa(i)+"."+tt.literal, func(t *testing.T) {
+			pb := tt.value.toYDB(allocator.New())
+			fmt.Println(pb)
 			require.Equal(t, tt.literal, tt.value.Yql())
 		})
 	}