Merge pull request #903 from Mixalight/Switch-golangci-config-from-opt-in-linters-to-opt-out

Change golangci to enable all

Author: asmyasnikov

.golangci.yml

@@ -225,66 +225,27 @@ linters-settings:
         # Default: false
         checkExported: true
 linters:
-  disable-all: true
-  enable:
-#    - cyclop
+  enable-all: true
+  disable:
+    - godot
+    - varnamelen
+    - wrapcheck
+    - nosnakecase
+    - deadcode
+    - golint
+    - interfacer
+    - maligned
+    - ifshort
+    - structcheck
+    - exhaustivestruct
+    - scopelint
+    - varcheck
+    - ireturn
     - depguard
-    - dogsled
-#    - dupl
-    - errcheck
-    - errorlint
-#    - exhaustive
-#    - exhaustivestruct
-#    - forbidigo
-#    - funlen
-#    - gci
-#    - gocognit
-    - goconst
-    - gocritic
-    - gocyclo
-#    - godot
-    - godox
-    - gofmt # On why gofmt when goimports is enabled - https://github.com/golang/go/issues/21476
-    - gofumpt
-    - goheader
-    - goimports
-#    - gomnd
-#    - gomoddirectives
-#    - gomodguard
-    - gosec
-    - gosimple
-    - govet
-    - depguard
-#    - ifshort
-#    - ireturn
-    - lll
-    - makezero
-    - misspell
-    - ineffassign
-    - misspell
-    - nakedret
-    - nestif
-#    - nilnil
-#    - nlreturn
-    - nolintlint
-    - prealloc
-    - predeclared
-    - rowserrcheck
-    - revive
-    - staticcheck
-    - stylecheck
-#    - tagliatelle
-#    - testpackage
-#    - thelper
-#    - tenv
-    - typecheck
-    - unconvert
-    - unparam
-    - unused
-#    - varnamelen
-    - whitespace
-#    - wrapcheck
-#    - wsl
+    - wsl
+    - exhaustruct
+    - gci
+    - paralleltest #need be enabled
 
 issues:
   # List of regexps of issue texts to exclude, empty list by default.

connection.go

@@ -16,6 +16,8 @@ import (
 // Interface and list of clients may be changed in the future
 //
 // Deprecated: use directly *Driver type from ydb.Open instead
+//
+//nolint:interfacebloat
 type Connection interface {
 	// Endpoint returns initial endpoint
 	Endpoint() string

driver.go

@@ -101,10 +101,13 @@ func (d *Driver) trace() *trace.Driver {
 	if d.config != nil {
 		return d.config.Trace()
 	}
+
 	return &trace.Driver{}
 }
 
 // Close closes Driver and clear resources
+//
+//nolint:nonamedreturns
 func (d *Driver) Close(ctx context.Context) (finalErr error) {
 	onDone := trace.DriverOnClose(d.trace(), &ctx, stack.FunctionID(""))
 	defer func() {
@@ -214,6 +217,8 @@ func (d *Driver) Topic() topic.Client {
 //	"grpc[s]://{endpoint}/{database}[?param=value]"
 //
 // See sugar.DSN helper for make dsn from endpoint and database
+//
+//nolint:nonamedreturns
 func Open(ctx context.Context, dsn string, opts ...Option) (_ *Driver, err error) {
 	d, err := newConnectionFromOptions(ctx, append(
 		[]Option{
@@ -246,12 +251,15 @@ func MustOpen(ctx context.Context, dsn string, opts ...Option) *Driver {
 	if err != nil {
 		panic(err)
 	}
+
 	return db
 }
 
 // New connects to database and return driver runtime holder
 //
 // Deprecated: use Open with required param connectionString instead
+//
+//nolint:nonamedreturns
 func New(ctx context.Context, opts ...Option) (_ *Driver, err error) {
 	d, err := newConnectionFromOptions(ctx, opts...)
 	if err != nil {
@@ -274,6 +282,7 @@ func New(ctx context.Context, opts ...Option) (_ *Driver, err error) {
 	return d, nil
 }
 
+//nolint:cyclop, nonamedreturns
 func newConnectionFromOptions(ctx context.Context, opts ...Option) (_ *Driver, err error) {
 	ctx, driverCtxCancel := xcontext.WithCancel(xcontext.WithoutDeadline(ctx))
 	defer func() {
@@ -321,16 +330,16 @@ func newConnectionFromOptions(ctx context.Context, opts ...Option) (_ *Driver, e
 	}
 	if d.logger != nil {
 		for _, opt := range []Option{
-			WithTraceDriver(log.Driver(d.logger, d.loggerDetails, d.loggerOpts...)),
-			WithTraceTable(log.Table(d.logger, d.loggerDetails, d.loggerOpts...)),
-			WithTraceScripting(log.Scripting(d.logger, d.loggerDetails, d.loggerOpts...)),
+			WithTraceDriver(log.Driver(d.logger, d.loggerDetails, d.loggerOpts...)),       //nolint:contextcheck
+			WithTraceTable(log.Table(d.logger, d.loggerDetails, d.loggerOpts...)),         //nolint:contextcheck
+			WithTraceScripting(log.Scripting(d.logger, d.loggerDetails, d.loggerOpts...)), //nolint:contextcheck
 			WithTraceScheme(log.Scheme(d.logger, d.loggerDetails, d.loggerOpts...)),
 			WithTraceCoordination(log.Coordination(d.logger, d.loggerDetails, d.loggerOpts...)),
 			WithTraceRatelimiter(log.Ratelimiter(d.logger, d.loggerDetails, d.loggerOpts...)),
-			WithTraceDiscovery(log.Discovery(d.logger, d.loggerDetails, d.loggerOpts...)),
-			WithTraceTopic(log.Topic(d.logger, d.loggerDetails, d.loggerOpts...)),
-			WithTraceDatabaseSQL(log.DatabaseSQL(d.logger, d.loggerDetails, d.loggerOpts...)),
-			WithTraceRetry(log.Retry(d.logger, d.loggerDetails, d.loggerOpts...)),
+			WithTraceDiscovery(log.Discovery(d.logger, d.loggerDetails, d.loggerOpts...)),     //nolint:contextcheck
+			WithTraceTopic(log.Topic(d.logger, d.loggerDetails, d.loggerOpts...)),             //nolint:contextcheck
+			WithTraceDatabaseSQL(log.DatabaseSQL(d.logger, d.loggerDetails, d.loggerOpts...)), //nolint:contextcheck
+			WithTraceRetry(log.Retry(d.logger, d.loggerDetails, d.loggerOpts...)),             //nolint:contextcheck
 		} {
 			if opt != nil {
 				err = opt(ctx, d)
@@ -341,16 +350,18 @@ func newConnectionFromOptions(ctx context.Context, opts ...Option) (_ *Driver, e
 		}
 	}
 	d.config = config.New(d.options...)
+
 	return d, nil
 }
 
+//nolint:cyclop, nonamedreturns, funlen
 func (d *Driver) connect(ctx context.Context) (err error) {
 	if d.config.Endpoint() == "" {
-		return xerrors.WithStackTrace(errors.New("configuration: empty dial address"))
+		return xerrors.WithStackTrace(errors.New("configuration: empty dial address")) //nolint:goerr113
 	}
 
 	if d.config.Database() == "" {
-		return xerrors.WithStackTrace(errors.New("configuration: empty database"))
+		return xerrors.WithStackTrace(errors.New("configuration: empty database")) //nolint:goerr113
 	}
 
 	if d.userInfo != nil {

errors.go

@@ -83,6 +83,8 @@ func IsOperationErrorSchemeError(err error) bool {
 }
 
 // IsOperationErrorTransactionLocksInvalidated checks does err a TLI issue
+//
+//nolint:nonamedreturns
 func IsOperationErrorTransactionLocksInvalidated(err error) (isTLI bool) {
 	return xerrors.IsOperationErrorTransactionLocksInvalidated(err)
 }