Skip to content

Commit afc803b

Browse files
committed
fixed TestDatabaseSqlMetrics and helpers SQLDriver
1 parent 9db993e commit afc803b

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

tests/integration/database_sql_metrics_test.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,12 @@ func TestDatabaseSqlMetrics(t *testing.T) {
3535
[]string{"database.sql.conns{}", "database.sql.tx{}"},
3636
xslices.Keys(registry.gauges.data),
3737
)
38-
require.EqualValues(t, 1, registry.gauges.data["database.sql.conns{}"].gauges["database.sql.conns{}"].value)
38+
require.NotNil(t, registry.gauges.data["database.sql.conns{}"].gauges)
3939

4040
cc1, err := db.Conn(ctx)
4141
require.NoError(t, err)
4242
require.NotNil(t, cc1)
43+
require.NotNil(t, registry.gauges.data["database.sql.conns{}"].gauges["database.sql.conns{}"])
4344
require.EqualValues(t, 1, registry.gauges.data["database.sql.conns{}"].gauges["database.sql.conns{}"].value)
4445
require.Empty(t, registry.gauges.data["database.sql.tx{}"].gauges)
4546

tests/integration/helpers_test.go

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,19 +145,17 @@ func (scope *scopeT) driverNamed(name string, opts ...ydb.Option) *ydb.Driver {
145145
func (scope *scopeT) SQLDriver(opts ...ydb.ConnectorOption) *sql.DB {
146146
f := func() (*fixenv.GenericResult[*sql.DB], error) {
147147
driver := scope.Driver()
148-
scope.Logf("Create sql db connector")
148+
scope.Logf("Create database/sql connector for YDB")
149149
connector, err := ydb.Connector(driver, opts...)
150150
if err != nil {
151151
return nil, err
152152
}
153153

154154
db := sql.OpenDB(connector)
155155

156-
clean := func() {
156+
return fixenv.NewGenericResultWithCleanup(db, func() {
157157
scope.Require.NoError(db.Close())
158-
}
159-
160-
return fixenv.NewGenericResultWithCleanup(db, clean), nil
158+
}), nil
161159
}
162160
return fixenv.CacheResult(scope.Env, f)
163161
}

0 commit comments

Comments
 (0)