Extract fast clock to xtest

Author: rekby

internal/topic/topicwriterinternal/writer_reconnector_test.go

@@ -14,7 +14,6 @@ import (
 	"testing"
 	"time"
 
-	"github.com/jonboulle/clockwork"
 	"github.com/stretchr/testify/require"
 	"go.uber.org/mock/gomock"
 
@@ -428,19 +427,7 @@ func TestWriterImpl_Reconnect(t *testing.T) {
 	xtest.TestManyTimesWithName(t, "ReconnectOnErrors", func(t testing.TB) {
 		ctx := xtest.Context(t)
 
-		clock := clockwork.NewFakeClock()
-
-		go func() {
-			for {
-				if ctx.Err() != nil {
-					return
-				}
-				clock.Advance(time.Second)
-				time.Sleep(time.Microsecond)
-			}
-		}()
-
-		w := newTestWriterStopped(WithClock(clock), WithTokenUpdateInterval(time.Duration(math.MaxInt64)))
+		w := newTestWriterStopped(WithClock(xtest.FastClock(t)), WithTokenUpdateInterval(time.Duration(math.MaxInt64)))
 
 		mc := gomock.NewController(t)
 

internal/xtest/clock.go

@@ -0,0 +1,37 @@
+package xtest
+
+import (
+	"sync/atomic"
+	"testing"
+	"time"
+
+	"github.com/jonboulle/clockwork"
+)
+
+// FastClock returns fake clock with very fast time speed advanced until end of test
+// the clock stops advance at end of test
+func FastClock(t testing.TB) clockwork.FakeClock {
+	clock := clockwork.NewFakeClock()
+	var needStop atomic.Bool
+	clockStopped := make(chan struct{})
+
+	go func() {
+		defer close(clockStopped)
+
+		for {
+			if needStop.Load() {
+				return
+			}
+
+			clock.Advance(time.Second)
+			time.Sleep(time.Microsecond)
+		}
+	}()
+
+	t.Cleanup(func() {
+		needStop.Store(true)
+		<-clockStopped
+	})
+
+	return clock
+}