removed unnessesarry linters from config. removed KeepInCache

Author: asmyasnikov

.golangci.yml

@@ -127,7 +127,6 @@ linters:
   disable-all: true
   enable:
 #    - cyclop
-    - deadcode
     - depguard
     - dogsled
 #    - dupl
@@ -173,7 +172,6 @@ linters:
     - revive
     - staticcheck
     - stylecheck
-    - structcheck
 #    - tagliatelle
 #    - testpackage
 #    - thelper
@@ -183,7 +181,6 @@ linters:
     - unparam
     - unused
 #    - varnamelen
-    - varcheck
     - whitespace
 #    - wrapcheck
 #    - wsl

CHANGELOG.md

@@ -1,7 +1,9 @@
 * Added retry policy options for topics: `topic/topicoptions.WithReaderCheckRetryErrorFunction`, `topic/topicoptions.WithReaderStartTimeout`, `topic/topicoptions.WithWriterCheckRetryErrorFunction`, `topic/topicoptions.WithWriterStartTimeout`
-* Refactored `internal/conn` middlewares for `DRY`
+* Refactored `internal/conn` middlewares
 * Added `trace.tableSessionInfo.LastUsage()` method for get last usage timestamp
-* Fixed mutable behaviour of `tx.WithCommit()`
+* Reverted `tx.WithCommit()` changes for fix unstable behaviour of lazy transactions
+* Added `options.WithCommit()` option for execute query with auto-commit flag
+* Removed `trace.TableTransactionExecuteStartInfo.KeepInCache` field as redundant
 
 ## v3.41.0
 * Added option for set interval of auth token update in topic streams

internal/cmd/gtrace/writer.go

@@ -782,7 +782,6 @@ func (f flags) has(x flags) bool {
 }
 
 const (
-	//nolint
 	zeroFlags flags = 1 << iota >> 1
 	docs
 )

internal/table/transaction.go

@@ -47,9 +47,7 @@ func (tx *transaction) Execute(
 	query string, params *table.QueryParameters,
 	opts ...options.ExecuteDataQueryOption,
 ) (r result.Result, err error) {
-	onDone := trace.TableOnSessionTransactionExecute(
-		tx.s.config.Trace(), &ctx, tx.s, tx, queryFromText(query), params, false,
-	)
+	onDone := trace.TableOnSessionTransactionExecute(tx.s.config.Trace(), &ctx, tx.s, tx, queryFromText(query), params)
 	defer func() {
 		onDone(r, err)
 	}()

trace/table.go

@@ -179,8 +179,6 @@ type (
 		Tx         tableTransactionInfo
 		Query      tableDataQuery
 		Parameters tableQueryParameters
-		// Deprecated: has no effect (always false). See KeepInCache flag in underlying Execute query trace
-		KeepInCache bool
 	}
 	TableTransactionExecuteStatementStartInfo struct {
 		// Context make available context in trace callback function.