Merge pull request #1148 from ydb-platform/improve-pg-types

improve pg type stringification

Author: asmyasnikov

CHANGELOG.md

@@ -3,7 +3,8 @@
 * Added query pool metrics
 * Fixed logic of query session pool
 * Changed initialization of internal driver clients to lazy
-* Disabled the logic of background grpc-connection parking 
+* Disabled the logic of background grpc-connection parking
+* Improved stringification for postgres types
 
 ## v3.58.2
 * Added `trace.Query.OnSessionBegin` event

internal/types/types.go

@@ -479,7 +479,7 @@ func (v PgType) String() string {
 }
 
 func (v PgType) Yql() string {
-	return "pgunknown"
+	return fmt.Sprintf("PgType(%v)", v.OID)
 }
 
 func (v PgType) ToYDB(a *allocator.Allocator) *Ydb.Type {

internal/types/types_test.go

@@ -271,7 +271,7 @@ func TestTypeToString(t *testing.T) {
 		},
 		{
 			t: PgType{OID: pg.OIDUnknown},
-			s: "pgunknown",
+			s: "PgType(705)",
 		},
 	} {
 		t.Run(tt.s, func(t *testing.T) {

internal/value/value.go

@@ -1267,7 +1267,7 @@ func (v pgValue) Yql() string {
 	//nolint:godox
 	// TODO: call special function for unknown oids
 	// https://github.com/ydb-platform/ydb/issues/2706
-	return fmt.Sprintf("PgUnknown(%q)", v.val)
+	return fmt.Sprintf(`PgConst("%v", PgType(%v))`, v.val, v.t.OID)
 }
 
 type setValue struct {

internal/value/value_test.go

@@ -502,7 +502,7 @@ func TestValueYql(t *testing.T) {
 		},
 		{
 			value:   PgValue(pg.OIDUnknown, "123"),
-			literal: `PgUnknown("123")`,
+			literal: `PgConst("123", PgType(705))`,
 		},
 	} {
 		t.Run(strconv.Itoa(i)+"."+tt.literal, func(t *testing.T) {