Skip to content

Commit b955c5f

Browse files
committed
check nil pointer on close clients
1 parent 8c4d18a commit b955c5f

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

internal/ratelimiter/client.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,9 @@ type Client struct {
3232
}
3333

3434
func (c *Client) Close(ctx context.Context) error {
35+
if c == nil {
36+
return xerrors.WithStackTrace(errNilClient)
37+
}
3538
return nil
3639
}
3740

internal/scheme/client.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,9 @@ type Client struct {
2929
}
3030

3131
func (c *Client) Close(_ context.Context) error {
32+
if c == nil {
33+
return xerrors.WithStackTrace(errNilClient)
34+
}
3235
return nil
3336
}
3437

internal/scripting/client.go

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -246,6 +246,9 @@ func (c *Client) streamExecute(
246246
}
247247

248248
func (c *Client) Close(ctx context.Context) (err error) {
249+
if c == nil {
250+
return xerrors.WithStackTrace(errNilClient)
251+
}
249252
onDone := trace.ScriptingOnClose(c.config.Trace(), &ctx)
250253
defer func() {
251254
onDone(err)

internal/table/client.go

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -464,6 +464,10 @@ func (c *Client) Put(ctx context.Context, s Session) (err error) {
464464
// It returns first error occurred during stale sessions' deletion.
465465
// Note that even on error it calls Close() on each session.
466466
func (c *Client) Close(ctx context.Context) (err error) {
467+
if c == nil {
468+
return xerrors.WithStackTrace(errNilClient)
469+
}
470+
467471
onDone := trace.TableOnClose(c.config.Trace(), &ctx)
468472
defer func() {
469473
onDone(err)

0 commit comments

Comments
 (0)