Merge pull request #1682 from ydb-platform/fix-balancer-ban

asmyasnikov · web-flow · commit babe5b3b881a · 2025-03-12T22:11:05.000+03:00
allowBanned=false for preferred GetConnection
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,5 @@
+* Changed allowBanned=false for preferred node connections
+
 ## v3.101.0
 * Added `table.Client.ReadRows` method with internal retries
 
diff --git a/internal/balancer/connections_state.go b/internal/balancer/connections_state.go
@@ -89,7 +89,7 @@ func (s *connectionsState) GetConnection(ctx context.Context) (_ conn.Conn, fail
 func (s *connectionsState) preferConnection(ctx context.Context) conn.Conn {
 	if nodeID, hasPreferEndpoint := endpoint.ContextNodeID(ctx); hasPreferEndpoint {
 		c := s.connByNodeID[nodeID]
-		if c != nil && isOkConnection(c, true) {
+		if c != nil && isOkConnection(c, false) {
 			return c
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,5 @@`
	`1`	`+* Changed allowBanned=false for preferred node connections`
	`2`	`+`
`1`	`3`	`## v3.101.0`
`2`	`4`	* Added `table.Client.ReadRows` method with internal retries
`3`	`5`
Original file line number	Diff line number	Diff line change
`@@ -89,7 +89,7 @@ func (s *connectionsState) GetConnection(ctx context.Context) (_ conn.Conn, fail`
`89`	`89`	`func (s *connectionsState) preferConnection(ctx context.Context) conn.Conn {`
`90`	`90`	`if nodeID, hasPreferEndpoint := endpoint.ContextNodeID(ctx); hasPreferEndpoint {`
`91`	`91`	`c := s.connByNodeID[nodeID]`
`92`		`- if c != nil && isOkConnection(c, true) {`
	`92`	`+ if c != nil && isOkConnection(c, false) {`
`93`	`93`	`return c`
`94`	`94`	`}`
`95`	`95`	`}`