Skip to content

Commit bb2565c

Browse files
authored
Merge pull request #185 from ydb-platform/recover-panic
recover panic on trace calls
2 parents 74ddca6 + 9bf6818 commit bb2565c

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

62 files changed

+1916
-4278
lines changed

.github/workflows/gtrace.yml

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@ jobs:
1212
test:
1313
strategy:
1414
matrix:
15-
os: [ ubuntu-latest, macos-latest, windows-latest ]
16-
go: [1.14.x, 1.15.x, 1.16.x, 1.17.x]
15+
os: [ ubuntu-latest ]
16+
go: [1.17.x]
1717
runs-on: ${{ matrix.os }}
1818
steps:
1919
- name: Checkout
@@ -30,16 +30,15 @@ jobs:
3030
3131
- name: Build
3232
run: |
33-
go install ./cmd/gtrace
33+
go install ./internal/cmd/gtrace
3434
35-
- name: Remove committed codegen file for recreate with gtrace on next step
35+
- name: Clean and re-generate *_gtrace.go files
3636
run: |
37-
rm ./cmd/gtrace/internal/test/*_gtrace.go
37+
cd ./trace && rm -f *_gtrace.go && go generate
3838
39-
- name: Generate
39+
- name: Check generation
4040
run: |
41-
cd ./cmd/gtrace/internal/test/ && go generate
42-
43-
- name: Test
44-
run: |
45-
go test -v ./cmd/gtrace/internal/test/
41+
if [[ $(git status --porcelain) -ne 0 ]]; then
42+
echo "code-generation not compatible with gtrace output";
43+
exit 1;
44+
fi

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
* Refactored gtrace tool for generate `Compose` options
2+
* Added panic recover on trace calls in `Compose` call step
3+
* Added `trace.With{Discovery,Driver,Coordination,Ratelimiter,Table,Scheme,Scripting}PanicCallback` options
4+
* Added `ydb.WithPanicCallback` option
5+
16
## v3.16.12
27
* Fixed bug with check acquire error over `ydb.IsRatelimiterAcquireError`
38
* Added full changelog link to github release description

cmd/gtrace/LICENSE

Lines changed: 0 additions & 21 deletions
This file was deleted.

cmd/gtrace/Makefile

Lines changed: 0 additions & 40 deletions
This file was deleted.

cmd/gtrace/README.md

Lines changed: 0 additions & 255 deletions
This file was deleted.

cmd/gtrace/internal/test/test.go

Lines changed: 0 additions & 31 deletions
This file was deleted.

0 commit comments

Comments
 (0)