Skip to content

Commit bc7672f

Browse files
asmyasnikovasmyasnikov
authored
Merge pull request #1564 from ydb-platform/driver-value
* Fixed string representation of `TzTimestamp`, `TzDatetime` and `TzDate` type values + Added `database/sql/driver.Value` as type destination for almost ydb values
2 parents 81b83d4 + 6bd56e0 commit bc7672f

File tree

13 files changed

+571
-127
lines changed

13 files changed

+571
-127
lines changed

‎CHANGELOG.md‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
* Fixed string representation of `TzTimestamp`, `TzDatetime` and `TzDate` type values
2+
* Added `database/sql/driver.Value` as type destination for almost ydb values
3+
14
## v3.92.5
25
* Avoid retrying requests finished with 'UNAUTHORIZED' errors
36

‎internal/params/builder_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,7 @@ func TestBuilder(t *testing.T) {
355355
},
356356
Value: &Ydb.Value{
357357
Value: &Ydb.Value_TextValue{
358-
TextValue: "1973-11-29T21:33:09Z",
358+
TextValue: "1973-11-29T21:33:09,UTC",
359359
},
360360
},
361361
},
@@ -370,7 +370,7 @@ func TestBuilder(t *testing.T) {
370370
},
371371
Value: &Ydb.Value{
372372
Value: &Ydb.Value_TextValue{
373-
TextValue: "1973-11-29",
373+
TextValue: "1973-11-29,UTC",
374374
},
375375
},
376376
},
@@ -385,7 +385,7 @@ func TestBuilder(t *testing.T) {
385385
},
386386
Value: &Ydb.Value{
387387
Value: &Ydb.Value_TextValue{
388-
TextValue: "1973-11-29T21:33:09.000000Z",
388+
TextValue: "1973-11-29T21:33:09.000000,UTC",
389389
},
390390
},
391391
},

‎internal/params/dict_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -389,7 +389,7 @@ func TestDict(t *testing.T) {
389389
},
390390
Value: &Ydb.Value{
391391
Value: &Ydb.Value_TextValue{
392-
TextValue: "1973-11-29T21:33:09Z",
392+
TextValue: "1973-11-29T21:33:09,UTC",
393393
},
394394
},
395395
},
@@ -404,7 +404,7 @@ func TestDict(t *testing.T) {
404404
},
405405
Value: &Ydb.Value{
406406
Value: &Ydb.Value_TextValue{
407-
TextValue: "1973-11-29",
407+
TextValue: "1973-11-29,UTC",
408408
},
409409
},
410410
},
@@ -419,7 +419,7 @@ func TestDict(t *testing.T) {
419419
},
420420
Value: &Ydb.Value{
421421
Value: &Ydb.Value_TextValue{
422-
TextValue: "1973-11-29T21:33:09.000000Z",
422+
TextValue: "1973-11-29T21:33:09.000000,UTC",
423423
},
424424
},
425425
},

‎internal/params/list_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ func TestList(t *testing.T) {
388388
},
389389
Value: &Ydb.Value{
390390
Value: &Ydb.Value_TextValue{
391-
TextValue: "1973-11-29T21:33:09Z",
391+
TextValue: "1973-11-29T21:33:09,UTC",
392392
},
393393
},
394394
},
@@ -403,7 +403,7 @@ func TestList(t *testing.T) {
403403
},
404404
Value: &Ydb.Value{
405405
Value: &Ydb.Value_TextValue{
406-
TextValue: "1973-11-29",
406+
TextValue: "1973-11-29,UTC",
407407
},
408408
},
409409
},
@@ -418,7 +418,7 @@ func TestList(t *testing.T) {
418418
},
419419
Value: &Ydb.Value{
420420
Value: &Ydb.Value_TextValue{
421-
TextValue: "1973-11-29T21:33:09.000000Z",
421+
TextValue: "1973-11-29T21:33:09.000000,UTC",
422422
},
423423
},
424424
},

‎internal/params/optional_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ func TestOptional(t *testing.T) {
388388
},
389389
Value: &Ydb.Value{
390390
Value: &Ydb.Value_TextValue{
391-
TextValue: "1973-11-29T21:33:09Z",
391+
TextValue: "1973-11-29T21:33:09,UTC",
392392
},
393393
},
394394
},
@@ -403,7 +403,7 @@ func TestOptional(t *testing.T) {
403403
},
404404
Value: &Ydb.Value{
405405
Value: &Ydb.Value_TextValue{
406-
TextValue: "1973-11-29",
406+
TextValue: "1973-11-29,UTC",
407407
},
408408
},
409409
},
@@ -418,7 +418,7 @@ func TestOptional(t *testing.T) {
418418
},
419419
Value: &Ydb.Value{
420420
Value: &Ydb.Value_TextValue{
421-
TextValue: "1973-11-29T21:33:09.000000Z",
421+
TextValue: "1973-11-29T21:33:09.000000,UTC",
422422
},
423423
},
424424
},

‎internal/params/set_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ func TestSet(t *testing.T) {
388388
},
389389
Value: &Ydb.Value{
390390
Value: &Ydb.Value_TextValue{
391-
TextValue: "1973-11-29T21:33:09Z",
391+
TextValue: "1973-11-29T21:33:09,UTC",
392392
},
393393
},
394394
},
@@ -403,7 +403,7 @@ func TestSet(t *testing.T) {
403403
},
404404
Value: &Ydb.Value{
405405
Value: &Ydb.Value_TextValue{
406-
TextValue: "1973-11-29",
406+
TextValue: "1973-11-29,UTC",
407407
},
408408
},
409409
},
@@ -418,7 +418,7 @@ func TestSet(t *testing.T) {
418418
},
419419
Value: &Ydb.Value{
420420
Value: &Ydb.Value_TextValue{
421-
TextValue: "1973-11-29T21:33:09.000000Z",
421+
TextValue: "1973-11-29T21:33:09.000000,UTC",
422422
},
423423
},
424424
},

‎internal/params/struct_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -873,7 +873,7 @@ func TestStruct(t *testing.T) {
873873
Items: []*Ydb.Value{
874874
{
875875
Value: &Ydb.Value_TextValue{
876-
TextValue: "1973-11-29T21:33:09Z",
876+
TextValue: "1973-11-29T21:33:09,UTC",
877877
},
878878
},
879879
},
@@ -906,7 +906,7 @@ func TestStruct(t *testing.T) {
906906
Items: []*Ydb.Value{
907907
{
908908
Value: &Ydb.Value_TextValue{
909-
TextValue: "1973-11-29",
909+
TextValue: "1973-11-29,UTC",
910910
},
911911
},
912912
},
@@ -939,7 +939,7 @@ func TestStruct(t *testing.T) {
939939
Items: []*Ydb.Value{
940940
{
941941
Value: &Ydb.Value_TextValue{
942-
TextValue: "1973-11-29T21:33:09.000000Z",
942+
TextValue: "1973-11-29T21:33:09.000000,UTC",
943943
},
944944
},
945945
},

‎internal/params/tuple_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ func TestTuple(t *testing.T) {
388388
},
389389
Value: &Ydb.Value{
390390
Value: &Ydb.Value_TextValue{
391-
TextValue: "1973-11-29T21:33:09Z",
391+
TextValue: "1973-11-29T21:33:09,UTC",
392392
},
393393
},
394394
},
@@ -403,7 +403,7 @@ func TestTuple(t *testing.T) {
403403
},
404404
Value: &Ydb.Value{
405405
Value: &Ydb.Value_TextValue{
406-
TextValue: "1973-11-29",
406+
TextValue: "1973-11-29,UTC",
407407
},
408408
},
409409
},
@@ -418,7 +418,7 @@ func TestTuple(t *testing.T) {
418418
},
419419
Value: &Ydb.Value{
420420
Value: &Ydb.Value_TextValue{
421-
TextValue: "1973-11-29T21:33:09.000000Z",
421+
TextValue: "1973-11-29T21:33:09.000000,UTC",
422422
},
423423
},
424424
},

‎internal/params/variant_struct_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -414,7 +414,7 @@ func TestVariantStruct(t *testing.T) {
414414
},
415415
Value: &Ydb.Value{
416416
Value: &Ydb.Value_TextValue{
417-
TextValue: "1973-11-29T21:33:09Z",
417+
TextValue: "1973-11-29T21:33:09,UTC",
418418
},
419419
VariantIndex: 0,
420420
},
@@ -430,7 +430,7 @@ func TestVariantStruct(t *testing.T) {
430430
},
431431
Value: &Ydb.Value{
432432
Value: &Ydb.Value_TextValue{
433-
TextValue: "1973-11-29",
433+
TextValue: "1973-11-29,UTC",
434434
},
435435
VariantIndex: 0,
436436
},
@@ -446,7 +446,7 @@ func TestVariantStruct(t *testing.T) {
446446
},
447447
Value: &Ydb.Value{
448448
Value: &Ydb.Value_TextValue{
449-
TextValue: "1973-11-29T21:33:09.000000Z",
449+
TextValue: "1973-11-29T21:33:09.000000,UTC",
450450
},
451451
VariantIndex: 0,
452452
},

‎internal/params/variant_tuple_test.go‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -413,7 +413,7 @@ func TestVariantTuple(t *testing.T) {
413413
},
414414
Value: &Ydb.Value{
415415
Value: &Ydb.Value_TextValue{
416-
TextValue: "1973-11-29T21:33:09Z",
416+
TextValue: "1973-11-29T21:33:09,UTC",
417417
},
418418
VariantIndex: 0,
419419
},
@@ -429,7 +429,7 @@ func TestVariantTuple(t *testing.T) {
429429
},
430430
Value: &Ydb.Value{
431431
Value: &Ydb.Value_TextValue{
432-
TextValue: "1973-11-29",
432+
TextValue: "1973-11-29,UTC",
433433
},
434434
VariantIndex: 0,
435435
},
@@ -445,7 +445,7 @@ func TestVariantTuple(t *testing.T) {
445445
},
446446
Value: &Ydb.Value{
447447
Value: &Ydb.Value_TextValue{
448-
TextValue: "1973-11-29T21:33:09.000000Z",
448+
TextValue: "1973-11-29T21:33:09.000000,UTC",
449449
},
450450
VariantIndex: 0,
451451
},

0 commit comments

Comments
 (0)