Skip to content

Commit bd3c70d

Browse files
committed
fix grpc limit test
1 parent 8801638 commit bd3c70d

File tree

1 file changed

+9
-15
lines changed

1 file changed

+9
-15
lines changed

tests/integration/topic_read_writer_test.go

Lines changed: 9 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -27,9 +27,7 @@ import (
2727
"github.com/ydb-platform/ydb-go-sdk/v3/internal/version"
2828
"github.com/ydb-platform/ydb-go-sdk/v3/internal/xtest"
2929
"github.com/ydb-platform/ydb-go-sdk/v3/log"
30-
"github.com/ydb-platform/ydb-go-sdk/v3/query"
3130
"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicoptions"
32-
"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicreader"
3331
"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicsugar"
3432
"github.com/ydb-platform/ydb-go-sdk/v3/topic/topictypes"
3533
"github.com/ydb-platform/ydb-go-sdk/v3/topic/topicwriter"
@@ -529,8 +527,8 @@ func TestSendMessagesLargerThenGRPCLimit(t *testing.T) {
529527
}
530528
scope := newScope(t)
531529

532-
const maxGrpcMsgSize = 10000 // bytes
533-
const topicMessageSize = maxGrpcMsgSize / 3
530+
maxGrpcMsgSize := config.DefaultGRPCMsgSize // bytes
531+
topicMessageSize := 10 * 1024 * 1024
534532

535533
scope.Driver(ydb.WithGrpcMaxMessageSize(maxGrpcMsgSize))
536534
writer, err := scope.Driver().Topic().StartWriter(
@@ -540,7 +538,9 @@ func TestSendMessagesLargerThenGRPCLimit(t *testing.T) {
540538
scope.Require.NoError(err)
541539
defer writer.Close(scope.Ctx)
542540

543-
const messageCount = 50
541+
const messageCount = 20
542+
scope.Require.Greater(messageCount*topicMessageSize, maxGrpcMsgSize*2)
543+
544544
messages := make([]topicwriter.Message, messageCount)
545545
for i := range messages {
546546
messages[i] = topicwriter.Message{Data: bytes.NewReader(make([]byte, topicMessageSize))}
@@ -549,17 +549,11 @@ func TestSendMessagesLargerThenGRPCLimit(t *testing.T) {
549549
err = writer.Write(scope.Ctx, messages...)
550550
scope.Require.NoError(err)
551551

552-
for i := 1; i <= messageCount; i++ {
553-
err = scope.Driver().Query().DoTx(scope.Ctx, func(ctx context.Context, tx query.TxActor) error {
554-
batch, err := scope.TopicReader().PopMessagesBatchTx(scope.Ctx, tx, topicreader.WithBatchMaxCount(1))
555-
if err != nil {
556-
return err
557-
}
558-
scope.Require.Equal(int64(i), batch.Messages[0].SeqNo)
559-
return nil
560-
})
561-
552+
for lastSeqNo := int64(0); lastSeqNo < messageCount; {
553+
msg, err := scope.TopicReader().ReadMessage(scope.Ctx)
562554
scope.Require.NoError(err)
555+
_ = scope.TopicReader().Commit(scope.Ctx, msg)
556+
lastSeqNo = msg.SeqNo
563557
}
564558
}
565559

0 commit comments

Comments
 (0)