enabled nlreturn (#1027)

* enabled nlreturn + partial fix

* nlreturn refactoring pt.2

* fix nlreturn pt. 3

* nlreturn fixed

* fixed tests

* codegen fix

* fixed gtrace codegen

Author: size12

.golangci.yml

@@ -238,7 +238,6 @@ linters:
     - ireturn
     - maintidx
     - maligned
-    - nlreturn
     - nonamedreturns
     - paralleltest
     - protogetter

balancers/balancers.go

@@ -40,6 +40,7 @@ func (filterLocalDC) String() string {
 func PreferLocalDC(balancer *balancerConfig.Config) *balancerConfig.Config {
 	balancer.Filter = filterLocalDC{}
 	balancer.DetectLocalDC = true
+
 	return balancer
 }
 
@@ -49,6 +50,7 @@ func PreferLocalDC(balancer *balancerConfig.Config) *balancerConfig.Config {
 func PreferLocalDCWithFallBack(balancer *balancerConfig.Config) *balancerConfig.Config {
 	balancer = PreferLocalDC(balancer)
 	balancer.AllowFallback = true
+
 	return balancer
 }
 
@@ -61,6 +63,7 @@ func (locations filterLocations) Allow(_ balancerConfig.Info, c conn.Conn) bool
 			return true
 		}
 	}
+
 	return false
 }
 
@@ -91,6 +94,7 @@ func PreferLocations(balancer *balancerConfig.Config, locations ...string) *bala
 	}
 	sort.Strings(locations)
 	balancer.Filter = filterLocations(locations)
+
 	return balancer
 }
 
@@ -100,6 +104,7 @@ func PreferLocations(balancer *balancerConfig.Config, locations ...string) *bala
 func PreferLocationsWithFallback(balancer *balancerConfig.Config, locations ...string) *balancerConfig.Config {
 	balancer = PreferLocations(balancer, locations...)
 	balancer.AllowFallback = true
+
 	return balancer
 }
 
@@ -129,6 +134,7 @@ func Prefer(balancer *balancerConfig.Config, filter func(endpoint Endpoint) bool
 	balancer.Filter = filterFunc(func(_ balancerConfig.Info, c conn.Conn) bool {
 		return filter(c.Endpoint())
 	})
+
 	return balancer
 }
 
@@ -138,6 +144,7 @@ func Prefer(balancer *balancerConfig.Config, filter func(endpoint Endpoint) bool
 func PreferWithFallback(balancer *balancerConfig.Config, filter func(endpoint Endpoint) bool) *balancerConfig.Config {
 	balancer = Prefer(balancer, filter)
 	balancer.AllowFallback = true
+
 	return balancer
 }
 

balancers/balancers_test.go

@@ -66,5 +66,6 @@ func applyPreferFilter(info balancerConfig.Info, b *balancerConfig.Config, conns
 			res = append(res, c)
 		}
 	}
+
 	return res
 }

balancers/config.go

@@ -92,6 +92,7 @@ func CreateFromConfig(s string) (*balancerConfig.Config, error) {
 		if c.Fallback {
 			return PreferLocalDCWithFallBack(b), nil
 		}
+
 		return PreferLocalDC(b), nil
 	case preferTypeLocations:
 		if len(c.Locations) == 0 {
@@ -100,6 +101,7 @@ func CreateFromConfig(s string) (*balancerConfig.Config, error) {
 		if c.Fallback {
 			return PreferLocationsWithFallback(b, c.Locations...), nil
 		}
+
 		return PreferLocations(b, c.Locations...), nil
 	default:
 		return b, nil
@@ -125,6 +127,7 @@ func FromConfig(config string, opts ...fromConfigOption) *balancerConfig.Config
 		if h.errorHandler != nil {
 			h.errorHandler(err)
 		}
+
 		return h.fallbackBalancer
 	}
 

config/config.go

@@ -292,5 +292,6 @@ func (c *Config) With(opts ...Option) *Config {
 		c.trace,
 		c.metaOptions...,
 	)
+
 	return c
 }

config/defaults.go

@@ -64,6 +64,7 @@ func defaultGrpcOptions(t *trace.Driver, secure bool, tlsConfig *tls.Config) (op
 			insecure.NewCredentials(),
 		))
 	}
+
 	return opts
 }
 
@@ -72,6 +73,7 @@ func certPool() *x509.CertPool {
 	if err == nil {
 		return certPool
 	}
+
 	return x509.NewCertPool()
 }
 

coordination/example_test.go

@@ -14,6 +14,7 @@ func Example() {
 	db, err := ydb.Open(ctx, "grpc://localhost:2136/local")
 	if err != nil {
 		fmt.Printf("failed to connect: %v", err)
+
 		return
 	}
 	defer db.Close(ctx) // cleanup resources
@@ -28,12 +29,14 @@ func Example() {
 	})
 	if err != nil {
 		fmt.Printf("failed to create node: %v", err)
+
 		return
 	}
 	defer db.Coordination().DropNode(ctx, "/local/test")
 	e, c, err := db.Coordination().DescribeNode(ctx, "/local/test")
 	if err != nil {
 		fmt.Printf("failed to describe node: %v", err)
+
 		return
 	}
 	fmt.Printf("node description: %+v\nnode config: %+v\n", e, c)

discovery/example_test.go

@@ -12,12 +12,14 @@ func Example_discoverCluster() {
 	db, err := ydb.Open(ctx, "grpc://localhost:2136/local")
 	if err != nil {
 		fmt.Printf("failed to connect: %v", err)
+
 		return
 	}
 	defer db.Close(ctx) // cleanup resources
 	endpoints, err := db.Discovery().Discover(ctx)
 	if err != nil {
 		fmt.Printf("discover failed: %v", err)
+
 		return
 	}
 	fmt.Printf("%s endpoints:\n", db.Name())
@@ -31,12 +33,14 @@ func Example_whoAmI() {
 	db, err := ydb.Open(ctx, "grpc://localhost:2136/local")
 	if err != nil {
 		fmt.Printf("failed to connect: %v", err)
+
 		return
 	}
 	defer db.Close(ctx) // cleanup resources
 	whoAmI, err := db.Discovery().WhoAmI(ctx)
 	if err != nil {
 		fmt.Printf("discover failed: %v", err)
+
 		return
 	}
 	fmt.Printf("%s whoAmI: %s\n", db.Name(), whoAmI.String())

driver_string.go

@@ -18,5 +18,6 @@ func (d *Driver) String() string {
 		fmt.Fprintf(buffer, ",Credentials:%v", c.String())
 	}
 	buffer.WriteByte('}')
+
 	return buffer.String()
 }

driver_string_test.go

@@ -23,7 +23,7 @@ func TestDriver_String(t *testing.T) {
 				config.WithDatabase("local"),
 				config.WithSecure(false),
 			)},
-			s: `Driver{Endpoint:"localhost",Database:"local",Secure:false,Credentials:Anonymous{From:"github.com/ydb-platform/ydb-go-sdk/v3/config.defaultConfig(defaults.go:88)"}}`, //nolint:lll
+			s: `Driver{Endpoint:"localhost",Database:"local",Secure:false,Credentials:Anonymous{From:"github.com/ydb-platform/ydb-go-sdk/v3/config.defaultConfig(defaults.go:90)"}}`, //nolint:lll
 		},
 		{
 			name: xtest.CurrentFileLine(),
@@ -32,7 +32,7 @@ func TestDriver_String(t *testing.T) {
 				config.WithDatabase("local"),
 				config.WithSecure(true),
 			)},
-			s: `Driver{Endpoint:"localhost",Database:"local",Secure:true,Credentials:Anonymous{From:"github.com/ydb-platform/ydb-go-sdk/v3/config.defaultConfig(defaults.go:88)"}}`, //nolint:lll
+			s: `Driver{Endpoint:"localhost",Database:"local",Secure:true,Credentials:Anonymous{From:"github.com/ydb-platform/ydb-go-sdk/v3/config.defaultConfig(defaults.go:90)"}}`, //nolint:lll
 		},
 		{
 			name: xtest.CurrentFileLine(),